motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-07 17:53:56 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

hw/char/riscv_htif: Clarify MemoryRegionOps expect 32-bit accesses

Browse source 
Looking at htif_mm_ops[] read/write handlers, we notice they
expect 32-bit values to accumulate into to the 'fromhost' and
'tohost' 64-bit variables. Explicit by setting the .impl
min/max fields.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Acked-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Message-ID: <20241129154304.34946-4-philmd@linaro.org>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
This commit is contained in:
Philippe Mathieu-Daudé 2024-11-29 16:43:04 +01:00 • committed by Alistair Francis
parent be0a70b93f
commit d2ed9fffba
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
hw/char/riscv_htif.c
View file

@ -325,6 +325,10 @@ static const MemoryRegionOps htif_mm_ops = {
.read = htif_mm_read, .read = htif_mm_read,
.write = htif_mm_write, .write = htif_mm_write,
.endianness = DEVICE_LITTLE_ENDIAN, .endianness = DEVICE_LITTLE_ENDIAN,
.impl = {
.min_access_size = 4,
.max_access_size = 4,
},
}; };
HTIFState *htif_mm_init(MemoryRegion *address_space, Chardev *chr, HTIFState *htif_mm_init(MemoryRegion *address_space, Chardev *chr,