It must now return two dictionaries: One for the profiles that have been completely loaded and one for the profiles that are only metadata. We could probably improve on these a little bit, since all of these (except the material model) will now load all available quality profiles. I'll see if it is necessary to optimise that.
Contributes to issue CURA-4243.
My IDE shows the str(inst) representation of an object when indicating what value is in there. This makes it easier to find stuff. It'll also make debug prints more clear than the default <XmlMaterialProfile.XmlMaterialProfile.XmlMaterialProfile object at 0x12345678> stuff of Python.
Contributes to issue CURA-4243.
This is done a bit inconsistently because it's unclear whether metadata should be considered as one word or two. I'd say it is one word, not 'meta data', but people seem to disagree.
Contributes to issue CURA-4243.
This is because ContainerRegistry.saveAll has been removed. That function was only used by this test. I don't think it's worth keeping this unit test for the effort. It's only for code that's passed through in the version upgrade from 2.4 to 2.5 anyway.
Contributes to issue CURA-4243.
We only need the metadata of these machines (now that the ID is in the metadata). We won't need all of those machines because some of them are not added.
Contributes to issue CURA-4243.
This specialized InstanceContainersModel has an override that makes the model a bit more efficient when non-materials get their metadata updated.
Contributes to issue CURA-4243.
Since we now return all metadata at once from every file, we don't need this any more. We need to side-load the metadata anyway.
Contributes to issue CURA-4243.
Because the setName function checks if the name is equal to the previous name, but at that point the previous name doesn't exist.
Contributes to issue CURA-4243.
Turns out that the side bar header was requesting the metadata before the active material was set. Now I'm just saying that if the active material was not set, it should not be compatible.
Contributes to issue CURA-4243, side-ways.
We shouldn't write the name or ID, who are now in the metadata.
Also we should load the name and ID properly from the file.
Contributes to issue CURA-4243.
Because their implementation changed, these would have been implemented in some other way. Instead I use the getters and setters which are inherited from the parent class and therefore are already updated.
Contributes to issue CURA-4243.
This code was filtering on certain criteria, and then filtering the results based on an additional metadata field. Let's just move that last field in the original criteria too...
Contributes to issue CURA-4243.
We're creating the variable but then requesting the 0th element from the list each time... That can be more logical and more efficient.
Contributes to issue CURA-4243.