Commit graph

8923 commits

Author SHA1 Message Date
Remco Burema
f2088d7fc8
Don't take snapshot if no main window present.
You'll need the Uranium branch of the same (fix_is_visible) name if you don't want this to crash on slicing!
2021-01-29 07:59:54 +01:00
Ghostkeeper
a9bf3ed934
Revert "Small fix for slice before main window visible."
This reverts commit 35d6aad6cd.
This is causing a very weird crash when autoslice is enabled:
2021-01-28 12:12:35,379 - CRITICAL - [MainThread] cura.CrashHandler.__init__ [66]: An uncaught error has occurred!
2021-01-28 12:12:35,379 - CRITICAL - [MainThread] cura.CrashHandler.__init__ [69]: Traceback (most recent call last):
2021-01-28 12:12:35,379 - CRITICAL - [MainThread] cura.CrashHandler.__init__ [69]:   File "/home/trin/Gedeeld/Projects/Cura/plugins/CuraEngineBackend/CuraEngineBackend.py", line 270, in slice
2021-01-28 12:12:35,380 - CRITICAL - [MainThread] cura.CrashHandler.__init__ [69]:     self._createSnapshot()
2021-01-28 12:12:35,380 - CRITICAL - [MainThread] cura.CrashHandler.__init__ [69]:   File "/home/trin/Gedeeld/Projects/Cura/cura/Utils/Threading.py", line 31, in _call_on_qt_thread_wrapper
2021-01-28 12:12:35,380 - CRITICAL - [MainThread] cura.CrashHandler.__init__ [69]:     return func(*args, **kwargs)
2021-01-28 12:12:35,380 - CRITICAL - [MainThread] cura.CrashHandler.__init__ [69]:   File "/home/trin/Gedeeld/Projects/Cura/plugins/CuraEngineBackend/CuraEngineBackend.py", line 254, in _createSnapshot
2021-01-28 12:12:35,380 - CRITICAL - [MainThread] cura.CrashHandler.__init__ [69]:     if not CuraApplication.getInstance().isVisible:
2021-01-28 12:12:35,380 - CRITICAL - [MainThread] cura.CrashHandler.__init__ [69]: AttributeError: 'CuraApplication' object has no attribute 'isVisible'

The property exists all right. It's in the dir() of the CuraApplication instance. PyCharm's debug mode also gives a traceback when trying to evaluate the property. It clearly thinks it's there, but then it's not or something. Very weird. We need to take a better look at this than this quick fix.
2021-01-28 12:23:01 +01:00
Ghostkeeper
678516186e
Revert "Don't call @property function"
This reverts commit 3921cc86d1.
2021-01-28 12:22:47 +01:00
Ghostkeeper
3921cc86d1
Don't call @property function
It directly returns the boolean. No need to call it. Calling it crashes saying that a bool object can't be called.
2021-01-28 11:48:18 +01:00
Remco Burema
35d6aad6cd
Small fix for slice before main window visible. 2021-01-28 11:41:46 +01:00
Jaime van Kessel
b219f57b22
Merge branch 'dev' of https://github.com/BasF0/Cura 2021-01-27 10:56:35 +01:00
RFBomb
4c8c7ec162
Correct comment spacing 2021-01-25 23:17:51 -05:00
RFBomb
e6cb24cbbc
correct spacing again.... 2021-01-25 23:12:19 -05:00
RFBomb
5130b5814d
correct spacing 2021-01-25 23:08:35 -05:00
RFBomb
322e4ac904
Correct syntax error that prevented checkbox showing up 2021-01-25 23:06:32 -05:00
RFBomb
5813aa2f57
Adds checkbox for 'machine_use_extruder_offset_to_offset_coords' in printer settings page. 2021-01-25 13:16:17 -05:00
Remco Burema
497bfa4c68
Merge branch 'master' into CURA-7871_lowest_print_height 2021-01-22 18:40:39 +01:00
Remco Burema
e681a6d32d
Fix camera not found on pre-slice snapshot/thumbnail. 2021-01-22 18:07:59 +01:00
Ghostkeeper
5a99ae168b
Merge branch 'restore_ufp_thumbnail' 2021-01-22 11:51:30 +01:00
Ghostkeeper
f28b90a1a4
Make Line Type the default selection for layer view colour scheme
Implements CURA-7983.
Fixes #9154.
2021-01-22 11:04:59 +01:00
Remco Burema
9144f38814
Fix wrong import. 2021-01-21 09:04:39 +01:00
Remco Burema
f4ef3b44e3
Properly retrieve snapshot (now made on slice).
Circumvents the snapshot/thumbnail not working when the focus is not on the main window, even if the thread is main. This was an issue when writing a file to Digital Factory becasue that workflow uses a modal window.

Thanks for the idea Jelle!
2021-01-21 08:55:45 +01:00
Remco Burema
4fc0612806
Make a snapshot on slice instead of write.
In some cases, UFP-writing is going to be done when the OpenGL-context is off the main window. This doesn't work. That unfortunately also goes for this commit, but it's a work in progress.
2021-01-21 08:19:17 +01:00
bas
46933693a7 removed hardcoded 0: now using LayerPolygon.MoveCombingType 2021-01-20 21:56:44 +01:00
Remco Burema
0ba3833995
Merge pull request #9153 from Ultimaker/CURA-7865_Save_file_in_existing_project_mvp
CURA-7865 Save file in existing project mvp
2021-01-20 19:18:39 +01:00
Kostas Karmas
32df06c280 Add TODO comment to explain the commenting out of the snapshot
CURA-7865
2021-01-20 12:51:13 +01:00
Kostas Karmas
a72a58cca1 Comment out the generation of the snapshot
While generating UFP files from outside the main thread, the snapshot generation crashes Cura
due to the OpenGL context.

To avoid that, for the time being, we comment out the generation of the snapshot.

CURA-7865
2021-01-20 11:23:48 +01:00
Ghostkeeper
a9c8c63442
Catch environment errors removing temporary package files
Could be removed or not having access rights.

Fixes Sentry issue CURA-1K6.
2021-01-19 14:49:47 +01:00
fieldOfView
d790de8706 Fix loading scripts from all registered resource paths 2021-01-19 13:55:02 +01:00
Jaime van Kessel
ffccd687ac
Merge branch 'fix_machinesettings_floats' of https://github.com/fieldOfView/Cura 2021-01-18 15:53:57 +01:00
Jaime van Kessel
bc15ca2269
Merge branch 'fix_pause_at_height_default_value' of https://github.com/fieldOfView/Cura 2021-01-15 17:10:23 +01:00
Philip Lorenz
352fef3efa Adapt to Python 3.9 API changes
Python 3.9 now made the TreeBuilder.start() `attrs` parameter ([1])
mandatory on all implementations. Adapt the plugin accordingly.

[1] https://bugs.python.org/issue39495
2021-01-10 20:21:40 +01:00
fieldOfView
47723e9823 Fix definition of machine_gcode_flavor setting in PauseAtHeight 2021-01-03 13:22:51 +01:00
Ghostkeeper
ba9e10cfd8
Round temperatures when displaying them
These are long lines for some screens. It'll save a bit of space. No PID controller can really control down to fractional degrees.
Fan speed and flow rates are already integer settings. For speeds and retraction lenghts the fractions can be important.

Done for #8967.
2020-12-24 16:08:12 +01:00
Sekisback
b458005e7e add Marlin Advanced Pause Feature! 2020-12-24 09:46:19 +01:00
Jaime van Kessel
f442417ac6
Dont try to set unknown settings as per object settings when loading 3mf
CURA-7615
2020-12-23 16:31:25 +01:00
Jaime van Kessel
f338acd4f3
Read & write all generic metadata items from 3mf
CURA-7615
2020-12-23 13:49:52 +01:00
Jaime van Kessel
f9d0da7a12
Store creation & Modification date
CURA-7615
2020-12-23 13:42:40 +01:00
Jaime van Kessel
e69edae9aa
Store application name when saving 3MF file
CURA-7615
2020-12-23 13:32:27 +01:00
Jaime van Kessel
5b43c94c0b
Mark setting as disabled in perobject setting panel if it's enabled property requires it
This is a bit different from the rest, since hiding would mean that the setting can't be removed.

CURA-7569
2020-12-21 13:15:32 +01:00
Jaime van Kessel
19a8bd63ab
Remove unused variable
CURA-6682
2020-12-18 15:35:15 +01:00
Jaime van Kessel
49effbcd80
Disable survey button 2020-12-17 10:22:29 +01:00
Remco Burema
5e7eb2fc93
No need for leading 0 in load-image num-fields.
fixes #8906
2020-12-11 17:18:23 +01:00
Remco Burema
db33f67666
Partial revert: Don't remove 'Print Thin Walls'.
It still makes sense, even in a libArachne/Variable Line Width sense.

CURA-7148
2020-12-10 12:49:00 +01:00
Remco Burema
df8a716ac3
Remove old 'Print Thin Walls' and 'Fill Gsps'.
In favour of new variable line width processing (Arachne).

CURA-7148
2020-12-09 20:55:37 +01:00
Ghostkeeper
d53568c5db
Fix linear-scaling height map thickness
Previously it was using this 'peak_height' which is the total height of the model in scale_vector.y. However it was then multiplying the height map with that scale vector and adding the base height again a second time. So the scaling part was too thick and included the base height, and the total height of the mesh was also too big.
I also reduced an unnecessary re-calculation of the height_from_base parameter. And as a result we don't need the peak_height variable at all any more.

Fixes #8902.
2020-12-09 12:16:56 +01:00
Ghostkeeper
2fbbd79789
Merge branch 'CURA-7683_VersionUpgrader_for_libArachne_5.0' into libArachne_rebased 2020-12-08 15:33:07 +01:00
fieldOfView
0313b29dcf Fix validator for floats in Machine Settings dialog
The DoubleValidator depends on the system locale, requiring users with certain locales to enter floats with a comma instead of a dot (though confusingly floats are always represented with a decimal a dot). Instead of configuring the DoubleValidator with a locale that only accepts decimal dots, this commit uses a RegExpValidator, like other numeric fields in Cura does.
2020-12-07 16:04:21 +01:00
Chris Racioppo
4f8c4be34e Added break from loop 2020-12-06 14:08:46 -05:00
Chris Racioppo
cfed67076e Removing unused import 2020-12-06 13:46:37 -05:00
Chris Racioppo
efb79ae650 Create CreateThumbnail.py 2020-12-06 13:40:56 -05:00
Kostas Karmas
1416466f05 Enable the setting version update to 18 in VersionUpgrade49to50
Contributes to CURA-7683 and CURA-7656
2020-12-02 15:32:26 +01:00
Kostas Karmas
696844f1cf Add VersionUpgrader for libArachne 5.0
Things to note:

* Since there is no VersionUpgrader from 4.8 to 4.9, this versionUpgrader attempts to upgrade
  files made in 4.8. This means that it touches files with setting_version = 16.
* The upgrade of the setting_version to 18 is currently commented out because we are not entirely
  sure that 18 will be the setting_version in 5.0.
* This versionUpgrader removes the following three settings that were removed in libArachne
	* "Compensate Wall Overlaps"
	* "Compensate Outer Wall Overlaps"
	* "Compensate Inner Wall Overlaps"
* The VersionUpgrader also disabled Fuzzy Skin from any profiles that may have it enabled, as fuzzy
  skin currently doesn't work in libArachne.
* The printer definitions have NOT been updated to the new setting_version to avoid having to deal
  with an enormous merge conflict in case the setting_version of 5.0 is something other than 18.
* Since the VersionUpgrader does not alter the setting_version, it will run every time Cura starts.

In short, this versionUpgrader runs and removes the deleted settings but it does not really change
the setting_version of any files.

Contributes to CURA-7683 and CURA-7656
2020-12-02 12:04:06 +01:00
Jaime van Kessel
00bc1bfcdc
Add extra cast to author model
Contributes to #8817
2020-11-27 10:46:33 +01:00
Jaime van Kessel
53637fa891
Merge branch 'master' of https://github.com/racerxdl/Cura 2020-11-26 14:25:05 +01:00