3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-20 13:17:51 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Revert "Make all settingitems async"

Browse source 
This reverts commit d1afc63902.
It creates a problem in Windows where settings with dropdown menus
do no load anymore.
This commit is contained in:
Kostas Karmas 2020-07-16 09:34:36 +02:00
parent 5bc6f5510f
commit e9da3b7e9a
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
resources/qml/Settings/SettingView.qml
View file

@ -265,7 +265,10 @@ Item
property var globalPropertyProvider: inheritStackProvider
property bool externalResetHandler: false
asynchronous: true
//Qt5.4.2 and earlier has a bug where this causes a crash: https://bugreports.qt.io/browse/QTBUG-35989
//In addition, while it works for 5.5 and higher, the ordering of the actual combo box drop down changes,
//causing nasty issues when selecting different options. So disable asynchronous loading of enum type completely.
asynchronous: model.type !== "enum" && model.type !== "extruder" && model.type !== "optional_extruder"
active: model.type !== undefined
source: