From e9da3b7e9a0bad45441a946bf2be4f3e99ce8ecb Mon Sep 17 00:00:00 2001 From: Kostas Karmas Date: Thu, 16 Jul 2020 09:34:36 +0200 Subject: [PATCH] Revert "Make all settingitems async" This reverts commit d1afc6390258510450e6f061757025f62e257dcb. It creates a problem in Windows where settings with dropdown menus do no load anymore. --- resources/qml/Settings/SettingView.qml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/resources/qml/Settings/SettingView.qml b/resources/qml/Settings/SettingView.qml index 8a390bbaef..02e20a5a5b 100644 --- a/resources/qml/Settings/SettingView.qml +++ b/resources/qml/Settings/SettingView.qml @@ -265,7 +265,10 @@ Item property var globalPropertyProvider: inheritStackProvider property bool externalResetHandler: false - asynchronous: true + //Qt5.4.2 and earlier has a bug where this causes a crash: https://bugreports.qt.io/browse/QTBUG-35989 + //In addition, while it works for 5.5 and higher, the ordering of the actual combo box drop down changes, + //causing nasty issues when selecting different options. So disable asynchronous loading of enum type completely. + asynchronous: model.type !== "enum" && model.type !== "extruder" && model.type !== "optional_extruder" active: model.type !== undefined source: