3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-07 23:17:32 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Catch UnicodeDecodeErrors when parsing error messages from server

Browse source 
Stupid recursive errors.

Fixes Sentry issue CURA-3VB.
This commit is contained in:
Ghostkeeper 2022-05-20 12:55:59 +02:00
parent 64b29779ca
commit b5e3479c1c
No known key found for this signature in database
GPG key ID: D2A8871EE34EC59A
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
plugins/Marketplace/PackageList.py
View file

@ -244,7 +244,10 @@ class PackageList(ListModel):
def _downloadError(self, package_id: str, update: bool = False, reply: Optional["QNetworkReply"] = None, error: Optional["QNetworkReply.NetworkError"] = None) -> None: def _downloadError(self, package_id: str, update: bool = False, reply: Optional["QNetworkReply"] = None, error: Optional["QNetworkReply.NetworkError"] = None) -> None:
if reply: if reply:
try:
reply_string = bytes(reply.readAll()).decode() reply_string = bytes(reply.readAll()).decode()
except UnicodeDecodeError:
reply_string = "<error message is corrupt too>"
Logger.error(f"Failed to download package: {package_id} due to {reply_string}") Logger.error(f"Failed to download package: {package_id} due to {reply_string}")
self._package_manager.packageInstallingFailed.emit(package_id) self._package_manager.packageInstallingFailed.emit(package_id)