From b5e3479c1c8e9f76cb6bbf23434bedae178a6c39 Mon Sep 17 00:00:00 2001
From: Ghostkeeper <rubend@tutanota.com>
Date: Fri, 20 May 2022 12:55:59 +0200
Subject: [PATCH] Catch UnicodeDecodeErrors when parsing error messages from
 server

Stupid recursive errors.

Fixes Sentry issue CURA-3VB.
---
 plugins/Marketplace/PackageList.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/plugins/Marketplace/PackageList.py b/plugins/Marketplace/PackageList.py
index 30162afe6c..3306e10740 100644
--- a/plugins/Marketplace/PackageList.py
+++ b/plugins/Marketplace/PackageList.py
@@ -244,7 +244,10 @@ class PackageList(ListModel):
 
     def _downloadError(self, package_id: str, update: bool = False, reply: Optional["QNetworkReply"] = None, error: Optional["QNetworkReply.NetworkError"] = None) -> None:
         if reply:
-            reply_string = bytes(reply.readAll()).decode()
+            try:
+                reply_string = bytes(reply.readAll()).decode()
+            except UnicodeDecodeError:
+                reply_string = "<error message is corrupt too>"
             Logger.error(f"Failed to download package: {package_id} due to {reply_string}")
         self._package_manager.packageInstallingFailed.emit(package_id)