3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-15 10:47:49 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fix check if definition with ID exists

Browse source 
It's not an InstanceContainer but a DefinitionContainer.
Also, when checking with the ID, it'll short circuit to the dictionary look up by ID. Then it's faster to directly check without specifying what type of container it is to prevent another nested function call.

Contributes to issue CURA-6793.
This commit is contained in:
Ghostkeeper 2019-10-10 15:36:19 +02:00
parent 38e723b51c
commit ab4fade017
No known key found for this signature in database
GPG key ID: 86BEF881AE2CF276
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
cura/Machines/ContainerTree.py
View file

@ -91,7 +91,7 @@ class ContainerTree:
# \param definition_id The definition to look for. # \param definition_id The definition to look for.
# \return Whether or not a printer definition exists with that name. # \return Whether or not a printer definition exists with that name.
def __contains__(self, definition_id: str) -> bool: def __contains__(self, definition_id: str) -> bool:
return len(ContainerRegistry.getInstance().findInstanceContainersMetadata(id = definition_id)) == 0 return len(ContainerRegistry.getInstance().findContainersMetadata(id = definition_id)) == 0
## Returns a machine node for the specified definition ID. ## Returns a machine node for the specified definition ID.
# #