From ab4fade01764660589c86a5b19a0825cb1e8e2b4 Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Thu, 10 Oct 2019 15:36:19 +0200 Subject: [PATCH] Fix check if definition with ID exists It's not an InstanceContainer but a DefinitionContainer. Also, when checking with the ID, it'll short circuit to the dictionary look up by ID. Then it's faster to directly check without specifying what type of container it is to prevent another nested function call. Contributes to issue CURA-6793. --- cura/Machines/ContainerTree.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cura/Machines/ContainerTree.py b/cura/Machines/ContainerTree.py index 4793945863..2901ee29a4 100644 --- a/cura/Machines/ContainerTree.py +++ b/cura/Machines/ContainerTree.py @@ -91,7 +91,7 @@ class ContainerTree: # \param definition_id The definition to look for. # \return Whether or not a printer definition exists with that name. def __contains__(self, definition_id: str) -> bool: - return len(ContainerRegistry.getInstance().findInstanceContainersMetadata(id = definition_id)) == 0 + return len(ContainerRegistry.getInstance().findContainersMetadata(id = definition_id)) == 0 ## Returns a machine node for the specified definition ID. #