PR review changes

This commit is contained in:
Dimitriovski 2020-01-27 13:25:29 +01:00
parent 537891d80b
commit aa2c612925
No known key found for this signature in database
GPG key ID: 4E62757E2B0D304D
2 changed files with 3 additions and 3 deletions

View file

@ -20,7 +20,7 @@ UM.Dialog{
maximumHeight: minimumHeight maximumHeight: minimumHeight
margin: 0 margin: 0
property string buttonText: subscribedPackagesModel.hasIncompatiblePackages && !subscribedPackagesModel.hasCompatiblePackages ? "Dismiss" : "Next" property string actionButtonText: subscribedPackagesModel.hasIncompatiblePackages && !subscribedPackagesModel.hasCompatiblePackages ? "Dismiss" : "Next"
Rectangle Rectangle
{ {
@ -140,7 +140,7 @@ UM.Dialog{
anchors.bottom: parent.bottom anchors.bottom: parent.bottom
anchors.right: parent.right anchors.right: parent.right
anchors.margins: UM.Theme.getSize("default_margin").height anchors.margins: UM.Theme.getSize("default_margin").height
text: catalog.i18nc("@button", buttonText) text: catalog.i18nc("@button", actionButtonText)
onClicked: accept() onClicked: accept()
leftPadding: UM.Theme.getSize("dialog_primary_button_padding").width leftPadding: UM.Theme.getSize("dialog_primary_button_padding").width
rightPadding: UM.Theme.getSize("dialog_primary_button_padding").width rightPadding: UM.Theme.getSize("dialog_primary_button_padding").width

View file

@ -42,7 +42,7 @@ class CloudPackageChecker(QObject):
self._getUserSubscribedPackages() self._getUserSubscribedPackages()
def _getUserSubscribedPackages(self) -> None: def _getUserSubscribedPackages(self) -> None:
Logger.log("d", "Requesting subscribed packages metadata from server.") Logger.debug("Requesting subscribed packages metadata from server.")
url = CloudApiModel.api_url_user_packages url = CloudApiModel.api_url_user_packages
self._application.getHttpRequestManager().get(url, self._application.getHttpRequestManager().get(url,
callback = self._onUserPackagesRequestFinished, callback = self._onUserPackagesRequestFinished,