From aa2c612925fc15066a07393af456208130d6797d Mon Sep 17 00:00:00 2001 From: Dimitriovski Date: Mon, 27 Jan 2020 13:25:29 +0100 Subject: [PATCH] PR review changes --- plugins/Toolbox/resources/qml/dialogs/CompatibilityDialog.qml | 4 ++-- plugins/Toolbox/src/CloudSync/CloudPackageChecker.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/Toolbox/resources/qml/dialogs/CompatibilityDialog.qml b/plugins/Toolbox/resources/qml/dialogs/CompatibilityDialog.qml index 73a1b7ec18..7c0b50c655 100644 --- a/plugins/Toolbox/resources/qml/dialogs/CompatibilityDialog.qml +++ b/plugins/Toolbox/resources/qml/dialogs/CompatibilityDialog.qml @@ -20,7 +20,7 @@ UM.Dialog{ maximumHeight: minimumHeight margin: 0 - property string buttonText: subscribedPackagesModel.hasIncompatiblePackages && !subscribedPackagesModel.hasCompatiblePackages ? "Dismiss" : "Next" + property string actionButtonText: subscribedPackagesModel.hasIncompatiblePackages && !subscribedPackagesModel.hasCompatiblePackages ? "Dismiss" : "Next" Rectangle { @@ -140,7 +140,7 @@ UM.Dialog{ anchors.bottom: parent.bottom anchors.right: parent.right anchors.margins: UM.Theme.getSize("default_margin").height - text: catalog.i18nc("@button", buttonText) + text: catalog.i18nc("@button", actionButtonText) onClicked: accept() leftPadding: UM.Theme.getSize("dialog_primary_button_padding").width rightPadding: UM.Theme.getSize("dialog_primary_button_padding").width diff --git a/plugins/Toolbox/src/CloudSync/CloudPackageChecker.py b/plugins/Toolbox/src/CloudSync/CloudPackageChecker.py index 8b20fe93ad..a14341a4b7 100644 --- a/plugins/Toolbox/src/CloudSync/CloudPackageChecker.py +++ b/plugins/Toolbox/src/CloudSync/CloudPackageChecker.py @@ -42,7 +42,7 @@ class CloudPackageChecker(QObject): self._getUserSubscribedPackages() def _getUserSubscribedPackages(self) -> None: - Logger.log("d", "Requesting subscribed packages metadata from server.") + Logger.debug("Requesting subscribed packages metadata from server.") url = CloudApiModel.api_url_user_packages self._application.getHttpRequestManager().get(url, callback = self._onUserPackagesRequestFinished,