3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-15 10:47:49 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Remove unnecessary newCloudPrintersDetected variable

Browse source 
Variable newCloudPrintersDetected is no longer needed, as it is communicated through the
signal itself.

CURA-7022
This commit is contained in:
Kostas Karmas 2020-04-29 13:47:11 +02:00
parent eda868f938
commit 58b61f2331
1 changed files with 0 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

7
cura/Machines/Models/DiscoveredCloudPrintersModel.py
View file

@ -25,7 +25,6 @@ class DiscoveredCloudPrintersModel(ListModel):
self.addRoleName(self.DeviceFirmwareVersionRole, "firmware_version")
self._discovered_ultimaker_cloud_printers_list = [] # type: List[Dict[str, str]]
self._new_cloud_printers_detected = False # type: bool
self._application = application # type: CuraApplication
def addDiscoveredCloudPrinters(self, new_devices: List[Dict[str, str]]) -> None:
@ -33,14 +32,12 @@ class DiscoveredCloudPrintersModel(ListModel):
self._update()
# Inform whether new cloud printers have been detected. If they have, the welcome wizard can close.
self._new_cloud_printers_detected = len(new_devices) > 0
self.cloudPrintersDetectedChanged.emit(len(new_devices) > 0)
@pyqtSlot()
def clear(self) -> None:
self._discovered_ultimaker_cloud_printers_list = []
self._update()
self._new_cloud_printers_detected = False
self.cloudPrintersDetectedChanged.emit(False)
def _update(self) -> None:
@ -54,7 +51,3 @@ class DiscoveredCloudPrintersModel(ListModel):
filtered_items.sort(key = lambda k: k["name"])
self.setItems(filtered_items)
@pyqtProperty(bool, notify = cloudPrintersDetectedChanged)
def newCloudPrintersDetected(self) -> bool:
return self._new_cloud_printers_detected