From 58b61f23316fdbef6d0c8f510c0cc805e9ae2ae9 Mon Sep 17 00:00:00 2001 From: Kostas Karmas Date: Wed, 29 Apr 2020 13:47:11 +0200 Subject: [PATCH] Remove unnecessary newCloudPrintersDetected variable Variable newCloudPrintersDetected is no longer needed, as it is communicated through the signal itself. CURA-7022 --- cura/Machines/Models/DiscoveredCloudPrintersModel.py | 7 ------- 1 file changed, 7 deletions(-) diff --git a/cura/Machines/Models/DiscoveredCloudPrintersModel.py b/cura/Machines/Models/DiscoveredCloudPrintersModel.py index e232afe8b9..cdd995484b 100644 --- a/cura/Machines/Models/DiscoveredCloudPrintersModel.py +++ b/cura/Machines/Models/DiscoveredCloudPrintersModel.py @@ -25,7 +25,6 @@ class DiscoveredCloudPrintersModel(ListModel): self.addRoleName(self.DeviceFirmwareVersionRole, "firmware_version") self._discovered_ultimaker_cloud_printers_list = [] # type: List[Dict[str, str]] - self._new_cloud_printers_detected = False # type: bool self._application = application # type: CuraApplication def addDiscoveredCloudPrinters(self, new_devices: List[Dict[str, str]]) -> None: @@ -33,14 +32,12 @@ class DiscoveredCloudPrintersModel(ListModel): self._update() # Inform whether new cloud printers have been detected. If they have, the welcome wizard can close. - self._new_cloud_printers_detected = len(new_devices) > 0 self.cloudPrintersDetectedChanged.emit(len(new_devices) > 0) @pyqtSlot() def clear(self) -> None: self._discovered_ultimaker_cloud_printers_list = [] self._update() - self._new_cloud_printers_detected = False self.cloudPrintersDetectedChanged.emit(False) def _update(self) -> None: @@ -54,7 +51,3 @@ class DiscoveredCloudPrintersModel(ListModel): filtered_items.sort(key = lambda k: k["name"]) self.setItems(filtered_items) - - @pyqtProperty(bool, notify = cloudPrintersDetectedChanged) - def newCloudPrintersDetected(self) -> bool: - return self._new_cloud_printers_detected