3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-22 06:03:57 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Remove superfluous error handling

Browse source 
If there is an error, it'll go into onError and handle the error there.

Contributes to issue CURA-8609.
This commit is contained in:
Ghostkeeper 2021-10-12 17:38:47 +02:00
parent bfb8d9ddf1
commit 2d53a548dc
No known key found for this signature in database
GPG key ID: 68F39EA88EEED5FF
1 changed files with 0 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

10
cura/PrinterOutput/UploadMaterialsJob.py
View file

@ -98,11 +98,6 @@ class UploadMaterialsJob(Job):
)
def onUploadRequestCompleted(self, reply: "QNetworkReply", error: Optional["QNetworkReply.NetworkError"]):
if error is not None:
Logger.error(f"Could not request URL to upload material archive to: {error}")
self.failed(UploadMaterialsError(catalog.i18nc("@text:error", "Failed to connect to Digital Factory.")))
return
response_data = HttpRequestManager.readJSON(reply)
if response_data is None:
Logger.error(f"Invalid response to material upload request. Could not parse JSON data.")
@ -130,11 +125,6 @@ class UploadMaterialsJob(Job):
)
def onUploadCompleted(self, reply: "QNetworkReply", error: Optional["QNetworkReply.NetworkError"]):
if error is not None:
Logger.error(f"Failed to upload material archive: {error}")
self.failed(UploadMaterialsError(catalog.i18nc("@text:error", "Failed to connect to Digital Factory.")))
return
for container_stack in self._printer_metadata:
cluster_id = container_stack["um_cloud_cluster_id"]
printer_id = container_stack["host_guid"]