From 2d53a548dca55af8e81bc49102004e230c09e03d Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Tue, 12 Oct 2021 17:38:47 +0200 Subject: [PATCH] Remove superfluous error handling If there is an error, it'll go into onError and handle the error there. Contributes to issue CURA-8609. --- cura/PrinterOutput/UploadMaterialsJob.py | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/cura/PrinterOutput/UploadMaterialsJob.py b/cura/PrinterOutput/UploadMaterialsJob.py index 8664e5b714..0c80ec94dc 100644 --- a/cura/PrinterOutput/UploadMaterialsJob.py +++ b/cura/PrinterOutput/UploadMaterialsJob.py @@ -98,11 +98,6 @@ class UploadMaterialsJob(Job): ) def onUploadRequestCompleted(self, reply: "QNetworkReply", error: Optional["QNetworkReply.NetworkError"]): - if error is not None: - Logger.error(f"Could not request URL to upload material archive to: {error}") - self.failed(UploadMaterialsError(catalog.i18nc("@text:error", "Failed to connect to Digital Factory."))) - return - response_data = HttpRequestManager.readJSON(reply) if response_data is None: Logger.error(f"Invalid response to material upload request. Could not parse JSON data.") @@ -130,11 +125,6 @@ class UploadMaterialsJob(Job): ) def onUploadCompleted(self, reply: "QNetworkReply", error: Optional["QNetworkReply.NetworkError"]): - if error is not None: - Logger.error(f"Failed to upload material archive: {error}") - self.failed(UploadMaterialsError(catalog.i18nc("@text:error", "Failed to connect to Digital Factory."))) - return - for container_stack in self._printer_metadata: cluster_id = container_stack["um_cloud_cluster_id"] printer_id = container_stack["host_guid"]