mirror of
https://github.com/Motorhead1991/qemu.git
synced 2025-07-27 04:13:53 -06:00
bc85aae420
Live migration should be terminated if the vhost-user backend crashes before the migration completes. Specifically, since the vhost device will be stopped when VM is stopped before the end of the live migration, in current implementation if the backend crashes, vhost-user device set_status() won't return failure, live migration won't perceive the disconnection between QEMU and the backend. When the VM is migrated to the destination, the inflight IO will be resubmitted, and if the IO was completed out of order before, it will cause IO error. To fix this issue: 1. Add the return value to set_status() for VirtioDeviceClass. a. For the vhost-user device, return failure when the backend crashes. b. For other virtio devices, always return 0. 2. Return failure if vhost_dev_stop() failed for vhost-user device. If QEMU loses connection with the vhost-user backend, virtio set_status() can return failure to the upper layer, migration_completion() can handle the error, terminate the live migration, and restore the VM, so that inflight IO can be completed normally. Signed-off-by: Haoqian He <haoqian.he@smartx.com> Message-Id: <20250416024729.3289157-4-haoqian.he@smartx.com> Tested-by: Lei Yang <leiyang@redhat.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
48 lines
1.2 KiB
C
48 lines
1.2 KiB
C
/*
|
|
* QEMU vhost-user backend
|
|
*
|
|
* Copyright (C) 2018 Red Hat Inc
|
|
*
|
|
* Authors:
|
|
* Marc-André Lureau <marcandre.lureau@redhat.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*/
|
|
#ifndef QEMU_VHOST_USER_BACKEND_H
|
|
#define QEMU_VHOST_USER_BACKEND_H
|
|
|
|
#include "qom/object.h"
|
|
#include "system/memory.h"
|
|
#include "qemu/option.h"
|
|
#include "qemu/bitmap.h"
|
|
#include "hw/virtio/vhost.h"
|
|
#include "hw/virtio/vhost-user.h"
|
|
#include "chardev/char-fe.h"
|
|
#include "io/channel.h"
|
|
|
|
#define TYPE_VHOST_USER_BACKEND "vhost-user-backend"
|
|
OBJECT_DECLARE_SIMPLE_TYPE(VhostUserBackend,
|
|
VHOST_USER_BACKEND)
|
|
|
|
|
|
|
|
struct VhostUserBackend {
|
|
/* private */
|
|
Object parent;
|
|
|
|
char *chr_name;
|
|
CharBackend chr;
|
|
VhostUserState vhost_user;
|
|
struct vhost_dev dev;
|
|
VirtIODevice *vdev;
|
|
bool started;
|
|
bool completed;
|
|
};
|
|
|
|
int vhost_user_backend_dev_init(VhostUserBackend *b, VirtIODevice *vdev,
|
|
unsigned nvqs, Error **errp);
|
|
void vhost_user_backend_start(VhostUserBackend *b);
|
|
int vhost_user_backend_stop(VhostUserBackend *b);
|
|
|
|
#endif
|