qemu/target/mips
Richard Henderson 256ba7715b target/mips: Simplify and fix update_pagemask
When update_pagemask was split from helper_mtc0_pagemask,
we failed to actually write to the new parameter but continue
to write to env->CP0_PageMask.  Thus the use within
page_table_walk_refill modifies cpu state and not the local
variable as expected.

Simplify by renaming to compute_pagemask and returning the
value directly.  No need for either env or pointer return.

Fixes: 074cfcb4da ("target/mips: Implement hardware page table walker for MIPS32")
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20250328175526.368121-4-richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Cc: qemu-stable@nongnu.org
2025-03-31 21:32:43 +02:00
..
system exec: Declare tlb_flush*() in 'exec/cputlb.h' 2025-03-08 07:56:14 -08:00
tcg target/mips: Simplify and fix update_pagemask 2025-03-31 21:32:43 +02:00
cpu-defs.c.inc target/mips: Introduce disas_mt_available() 2024-11-03 05:52:49 -03:00
cpu-param.h target/mips: Revert TARGET_PAGE_BITS_VARY 2025-03-31 21:32:43 +02:00
cpu-qom.h target: Move ArchCPUClass definition to 'cpu.h' 2023-11-07 13:08:48 +01:00
cpu.c target/mips: Move has_work() from CPUClass to SysemuCPUOps 2025-03-09 17:00:47 +01:00
cpu.h target/mips: Remove unused CPUMIPSState::current_fpu field 2024-11-03 05:52:49 -03:00
fpu.c target/mips: Optimize CPU/FPU regnames[] arrays 2021-05-02 16:49:34 +02:00
fpu_helper.h fpu: allow flushing of output denormals to be after rounding 2025-02-11 16:22:07 +00:00
gdbstub.c target/mips: Prefer fast cpu_env() over slower CPU QOM cast macro 2024-03-12 12:04:24 +01:00
helper.h include: Rename sysemu/ -> system/ 2024-12-20 17:44:56 +01:00
internal.h target/mips: Move has_work() from CPUClass to SysemuCPUOps 2025-03-09 17:00:47 +01:00
Kconfig target/mips: Restrict semihosting to TCG 2024-07-22 09:38:10 +01:00
kvm.c include: Rename sysemu/ -> system/ 2024-12-20 17:44:56 +01:00
kvm_mips.h kvm: Introduce kvm_arch_get_default_type hook 2023-08-22 17:31:02 +01:00
meson.build include: Rename sysemu/ -> system/ 2024-12-20 17:44:56 +01:00
mips-defs.h target/mips: Introduce disas_mt_available() 2024-11-03 05:52:49 -03:00
msa.c fpu: allow flushing of output denormals to be after rounding 2025-02-11 16:22:07 +00:00