mirror of
https://github.com/Motorhead1991/qemu.git
synced 2025-08-02 15:23:53 -06:00
ec150c7e09
Back in 2016, we discussed[1] rules for headers, and these were
generally liked:
1. Have a carefully curated header that's included everywhere first. We
got that already thanks to Peter: osdep.h.
2. Headers should normally include everything they need beyond osdep.h.
If exceptions are needed for some reason, they must be documented in
the header. If all that's needed from a header is typedefs, put
those into qemu/typedefs.h instead of including the header.
3. Cyclic inclusion is forbidden.
This patch gets include/ closer to obeying 2.
It's actually extracted from my "[RFC] Baby steps towards saner
headers" series[2], which demonstrates a possible path towards
checking 2 automatically. It passes the RFC test there.
[1] Message-ID: <87h9g8j57d.fsf@blackfin.pond.sub.org>
https://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg03345.html
[2] Message-Id: <20190711122827.18970-1-armbru@redhat.com>
https://lists.nongnu.org/archive/html/qemu-devel/2019-07/msg02715.html
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20190812052359.30071-2-armbru@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
57 lines
1.6 KiB
C
57 lines
1.6 KiB
C
/*
|
|
* TOD (Time Of Day) clock
|
|
*
|
|
* Copyright 2018 Red Hat, Inc.
|
|
* Author(s): David Hildenbrand <david@redhat.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*/
|
|
|
|
#ifndef HW_S390_TOD_H
|
|
#define HW_S390_TOD_H
|
|
|
|
#include "hw/qdev.h"
|
|
#include "target/s390x/s390-tod.h"
|
|
|
|
typedef struct S390TOD {
|
|
uint8_t high;
|
|
uint64_t low;
|
|
} S390TOD;
|
|
|
|
#define TYPE_S390_TOD "s390-tod"
|
|
#define S390_TOD(obj) OBJECT_CHECK(S390TODState, (obj), TYPE_S390_TOD)
|
|
#define S390_TOD_CLASS(oc) OBJECT_CLASS_CHECK(S390TODClass, (oc), \
|
|
TYPE_S390_TOD)
|
|
#define S390_TOD_GET_CLASS(obj) OBJECT_GET_CLASS(S390TODClass, (obj), \
|
|
TYPE_S390_TOD)
|
|
#define TYPE_KVM_S390_TOD TYPE_S390_TOD "-kvm"
|
|
#define TYPE_QEMU_S390_TOD TYPE_S390_TOD "-qemu"
|
|
|
|
typedef struct S390TODState {
|
|
/* private */
|
|
DeviceState parent_obj;
|
|
|
|
/*
|
|
* Used by TCG to remember the time base. Used by KVM to backup the TOD
|
|
* while the TOD is stopped.
|
|
*/
|
|
S390TOD base;
|
|
/* Used by KVM to remember if the TOD is stopped and base is valid. */
|
|
bool stopped;
|
|
} S390TODState;
|
|
|
|
typedef struct S390TODClass {
|
|
/* private */
|
|
DeviceClass parent_class;
|
|
void (*parent_realize)(DeviceState *dev, Error **errp);
|
|
|
|
/* public */
|
|
void (*get)(const S390TODState *td, S390TOD *tod, Error **errp);
|
|
void (*set)(S390TODState *td, const S390TOD *tod, Error **errp);
|
|
} S390TODClass;
|
|
|
|
void s390_init_tod(void);
|
|
S390TODState *s390_get_todstate(void);
|
|
|
|
#endif
|