mirror of
https://github.com/Motorhead1991/qemu.git
synced 2026-02-02 14:20:39 -07:00
d7bea75d35
The macro DO_UPCAST() is incorrectly named: it converts from a parent class to a derived class (which is a downcast). Better, and more consistent with some of the other qapi visitors, is to use the container_of() macro through a to_FOO() helper. Names like 'to_ov()' may be a bit short, but for a static helper it doesn't hurt too much, and matches existing practice in files like qmp-input-visitor.c. Our current definition of container_of() is weaker than DO_UPCAST(), in that it does not require the derived class to have Visitor as its first member, but this does not hurt our usage patterns in qapi visitors. Signed-off-by: Eric Blake <eblake@redhat.com> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> Message-Id: <1454075341-13658-3-git-send-email-eblake@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com> |
||
|---|---|---|
| .. | ||
| block-core.json | ||
| block.json | ||
| common.json | ||
| crypto.json | ||
| event.json | ||
| introspect.json | ||
| Makefile.objs | ||
| opts-visitor.c | ||
| qapi-dealloc-visitor.c | ||
| qapi-util.c | ||
| qapi-visit-core.c | ||
| qmp-dispatch.c | ||
| qmp-event.c | ||
| qmp-input-visitor.c | ||
| qmp-output-visitor.c | ||
| qmp-registry.c | ||
| rocker.json | ||
| string-input-visitor.c | ||
| string-output-visitor.c | ||
| trace.json | ||