mirror of
https://github.com/Motorhead1991/qemu.git
synced 2025-08-04 16:23:55 -06:00
![]() In cpu_loop_exec_tb(), we decide whether to look for a TB with exactly insns_left instructions in it using the condition (!cpu->icount_extra && insns_left > 0 && insns_left < tb->icount) The check for icount_extra == 0 is unnecessary, because we just set insns_left = MIN(0xffff, cpu->icount_budget); icount_extra = icount_budget - insns_left; and so icount_extra can only be non-zero if icount_budget > 0xffff and insns_left == 0xffff. But in that case insns_left >= tb->icount because 0xffff is much larger than TCG_MAX_INSNS, so the condition will be false anyway. Remove the unnecessary check, and instead assert: * that we are only going to execute a partial TB here if the icount budget has run out (ie icount_extra == 0) * that the number of insns we're going to execute does fit into the CF_COUNT_MASK Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Message-Id: <20210725174405.24568-3-peter.maydell@linaro.org> Signed-off-by: Richard Henderson <richard.henderson@linaro.org> |
||
---|---|---|
.. | ||
atomic_common.c.inc | ||
atomic_template.h | ||
cpu-exec-common.c | ||
cpu-exec.c | ||
cputlb.c | ||
hmp.c | ||
internal.h | ||
meson.build | ||
plugin-gen.c | ||
plugin-helpers.h | ||
tb-context.h | ||
tb-hash.h | ||
tcg-accel-ops-icount.c | ||
tcg-accel-ops-icount.h | ||
tcg-accel-ops-mttcg.c | ||
tcg-accel-ops-mttcg.h | ||
tcg-accel-ops-rr.c | ||
tcg-accel-ops-rr.h | ||
tcg-accel-ops.c | ||
tcg-accel-ops.h | ||
tcg-all.c | ||
tcg-runtime-gvec.c | ||
tcg-runtime.c | ||
tcg-runtime.h | ||
trace-events | ||
trace.h | ||
translate-all.c | ||
translator.c | ||
user-exec-stub.c | ||
user-exec.c |