mirror of
https://github.com/Motorhead1991/qemu.git
synced 2025-08-19 16:12:40 -06:00
2ec063788e
I was setting gpioV4-7 to "1110" using the QOM pin property handler and
noticed that lowering gpioV7 was inadvertently lowering gpioV4-6 too.
(qemu) qom-set /machine/soc/gpio gpioV4 true
(qemu) qom-set /machine/soc/gpio gpioV5 true
(qemu) qom-set /machine/soc/gpio gpioV6 true
(qemu) qom-get /machine/soc/gpio gpioV4
true
(qemu) qom-set /machine/soc/gpio gpioV7 false
(qemu) qom-get /machine/soc/gpio gpioV4
false
An expression in aspeed_gpio_set_pin_level was using a logical NOT
operator instead of a bitwise NOT operator:
value &= !pin_mask;
The original author probably intended to make a bitwise NOT expression
"~", but mistakenly used a logical NOT operator "!" instead. Some
programming languages like Rust use "!" for both purposes.
Fixes:
|
||
|---|---|---|
| .. | ||
| aspeed_gpio.c | ||
| bcm2835_gpio.c | ||
| gpio_key.c | ||
| gpio_pwr.c | ||
| imx_gpio.c | ||
| Kconfig | ||
| max7310.c | ||
| meson.build | ||
| mpc8xxx.c | ||
| npcm7xx_gpio.c | ||
| nrf51_gpio.c | ||
| omap_gpio.c | ||
| pl061.c | ||
| sifive_gpio.c | ||
| trace-events | ||
| trace.h | ||
| zaurus.c | ||