Kevin Wolf 8e4ffb4ef4 qcow2: Don't crash qemu-img info with missing crypto header ... qcow2_refresh_limits() assumes that s->crypto is non-NULL whenever bs->encrypted is true. This is actually not the case: qcow2_do_open() allows to open an image with a missing crypto header for BDRV_O_NO_IO, and then bs->encrypted is true, but s->crypto is still NULL. It doesn't make sense to open an invalid image, so remove the exception for BDRV_O_NO_IO. This catches the problem early and any code that makes the same assumption is safe now. At the same time, in the name of defensive programming, we shouldn't make the assumption in the first place. Let qcow2_refresh_limits() check s->crypto rather than bs->encrypted. If s->crypto is NULL, it also can't make any requirement on request alignment. Finally, start a qcow2-encryption test case that only serves as a regression test for this crash for now. Reported-by: Leonid Reviakin <L.reviakin@fobos-nt.ru> Reported-by: Denis Rastyogin <gerben@altlinux.org> Signed-off-by: Kevin Wolf <kwolf@redhat.com> Message-ID: <20250318201143.70657-1-kwolf@redhat.com> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>		2025-04-08 12:13:17 +02:00
..
export	block/export: Add option to allow export of inactive nodes	2025-02-06 14:46:40 +01:00
monitor	nbd/server: Allow users to adjust handshake limit in QMP	2025-02-11 13:45:47 -06:00
accounting.c	include: Rename sysemu/ -> system/	2024-12-20 17:44:56 +01:00
aio_task.c	block: Remove unused aio_task_pool_empty	2024-09-30 10:53:18 +03:00
amend.c	block: Mark BlockDriver callbacks for amend job GRAPH_RDLOCK	2023-05-10 14:16:54 +02:00
backup.c	include: Rename sysemu/ -> system/	2024-12-20 17:44:56 +01:00
blkdebug.c	qapi: Move include/qapi/qmp/ to include/qobject/	2025-02-10 15:33:16 +01:00
blkio.c	qapi: Move include/qapi/qmp/ to include/qobject/	2025-02-10 15:33:16 +01:00
blklogwrites.c	qapi: Move include/qapi/qmp/ to include/qobject/	2025-02-10 15:33:16 +01:00
blkreplay.c	include: Rename sysemu/ -> system/	2024-12-20 17:44:56 +01:00
blkverify.c	qapi: Move include/qapi/qmp/ to include/qobject/	2025-02-10 15:33:16 +01:00
block-backend.c	block: Remove unused blk_op_is_blocked()	2025-03-11 15:49:14 +01:00
block-copy.c	include: Rename sysemu/ -> system/	2024-12-20 17:44:56 +01:00
block-gen.h	block-coroutine-wrapper.py: support also basic return types	2022-12-15 16:07:43 +01:00
block-ram-registrar.c	include: Rename sysemu/ -> system/	2024-12-20 17:44:56 +01:00
bochs.c	block: Take graph lock for most of .bdrv_open	2023-11-08 17:56:18 +01:00
cloop.c	block: Take graph lock for most of .bdrv_open	2023-11-08 17:56:18 +01:00
commit.c	include: Rename sysemu/ -> system/	2024-12-20 17:44:56 +01:00
copy-before-write.c	qapi: Move include/qapi/qmp/ to include/qobject/	2025-02-10 15:33:16 +01:00
copy-before-write.h	backup: add minimum cluster size to performance options	2024-09-30 10:53:08 +03:00
copy-on-read.c	qapi: Move include/qapi/qmp/ to include/qobject/	2025-02-10 15:33:16 +01:00
copy-on-read.h	block: Mark bdrv_(un)freeze_backing_chain() and callers GRAPH_RDLOCK	2023-11-07 19:14:19 +01:00
coroutines.h	include: Rename sysemu/ -> system/	2024-12-20 17:44:56 +01:00
create.c	qemu/compiler: Absorb 'clang-tsa.h'	2025-03-06 14:21:25 +01:00
crypto.c	include: Rename sysemu/ -> system/	2024-12-20 17:44:56 +01:00
crypto.h	block: Support detached LUKS header creation using qemu-img	2024-02-09 12:50:37 +00:00
curl.c	qapi: Move include/qapi/qmp/ to include/qobject/	2025-02-10 15:33:16 +01:00
dirty-bitmap.c	block: Mark bdrv_*_dirty_bitmap() and callers GRAPH_RDLOCK	2023-02-23 19:49:32 +01:00
dmg-bz2.c	Include qemu-common.h exactly where needed	2019-06-12 13:20:20 +02:00
dmg-lzfse.c	block/dmg: Ignore C99 prototype declaration mismatch from <lzfse.h>	2023-03-30 15:03:36 +02:00
dmg.c	block: Protect bs->file with graph_lock	2023-11-08 17:56:18 +01:00
dmg.h	block/dmg: Declare a type definition for DMG uncompress function	2023-04-24 13:53:44 -04:00
file-posix.c	file-posix: Support FUA writes	2025-03-13 17:44:55 +01:00
file-win32.c	qapi: Move include/qapi/qmp/ to include/qobject/	2025-02-10 15:33:16 +01:00
filter-compress.c	block: Take graph lock for most of .bdrv_open	2023-11-08 17:56:18 +01:00
gluster.c	qapi: Move include/qapi/qmp/ to include/qobject/	2025-02-10 15:33:16 +01:00
graph-lock.c	graph-lock: remove AioContext locking	2023-12-21 22:49:27 +01:00
io.c	block/io: Ignore FUA with cache.no-flush=on	2025-03-13 17:57:23 +01:00
io_uring.c	file-posix: Support FUA writes	2025-03-13 17:44:55 +01:00
iscsi-opts.c	modules: add block module annotations	2021-07-09 18:20:27 +02:00
iscsi.c	qapi: Move include/qapi/qmp/ to include/qobject/	2025-02-10 15:33:16 +01:00
linux-aio.c	file-posix: Support FUA writes	2025-03-13 17:44:55 +01:00
meson.build	include: Rename sysemu/ -> system/	2024-12-20 17:44:56 +01:00
mirror.c	include: Rename sysemu/ -> system/	2024-12-20 17:44:56 +01:00
nbd.c	qapi: Move include/qapi/qmp/ to include/qobject/	2025-02-10 15:33:16 +01:00
nfs.c	qapi: Move include/qapi/qmp/ to include/qobject/	2025-02-10 15:33:16 +01:00
null.c	qapi: Move include/qapi/qmp/ to include/qobject/	2025-02-10 15:33:16 +01:00
nvme.c	qapi: Move include/qapi/qmp/ to include/qobject/	2025-02-10 15:33:16 +01:00
parallels-ext.c	qapi/crypto: Rename QCryptoHashAlgorithm to *Algo, and drop prefix	2024-09-10 14:02:16 +02:00
parallels.c	qapi: Move include/qapi/qmp/ to include/qobject/	2025-02-10 15:33:16 +01:00
parallels.h	block: Protect bs->file with graph_lock	2023-11-08 17:56:18 +01:00
preallocate.c	block: Protect bs->file with graph_lock	2023-11-08 17:56:18 +01:00
progress_meter.c	coroutine: Clean up superfluous inclusion of qemu/lockable.h	2023-01-19 10:18:28 +01:00
qapi-system.c	qapi: Move include/qapi/qmp/ to include/qobject/	2025-02-10 15:33:16 +01:00
qapi.c	Block layer patches	2025-02-10 13:25:36 -05:00
qcow.c	qapi: Move include/qapi/qmp/ to include/qobject/	2025-02-10 15:33:16 +01:00
qcow2-bitmap.c	block/qcow2-bitmap: Replace g_memdup() by g_memdup2()	2024-05-08 19:11:34 +02:00
qcow2-cache.c	qcow2: Mark qcow2_signal_corruption() and callers GRAPH_RDLOCK	2023-10-12 16:31:33 +02:00
qcow2-cluster.c	qcow2: Take locks for accessing bs->file	2023-11-08 17:56:17 +01:00
qcow2-refcount.c	qcow2: Mark qcow2_signal_corruption() and callers GRAPH_RDLOCK	2023-10-12 16:31:33 +02:00
qcow2-snapshot.c	include: Rename sysemu/ -> system/	2024-12-20 17:44:56 +01:00
qcow2-threads.c	thread-pool: avoid passing the pool parameter every time	2023-04-25 13:17:28 +02:00
qcow2.c	qcow2: Don't crash qemu-img info with missing crypto header	2025-04-08 12:13:17 +02:00
qcow2.h	qcow2: Take locks for accessing bs->file	2023-11-08 17:56:17 +01:00
qed-check.c	qed: mark more functions as coroutine_fns and GRAPH_RDLOCK	2023-06-28 09:46:20 +02:00
qed-cluster.c	qed: protect table cache with CoMutex	2017-07-17 11:34:11 +08:00
qed-l2-cache.c	osdep: Move memalign-related functions to their own header	2022-03-07 13:16:49 +00:00
qed-table.c	block: use bdrv_co_debug_event in coroutine context	2023-06-28 09:46:34 +02:00
qed.c	block/qed: fix use-after-free by nullifying timer pointer after free	2025-03-06 10:19:54 +08:00
qed.h	block: Protect bs->file with graph_lock	2023-11-08 17:56:18 +01:00
quorum.c	qapi: Move include/qapi/qmp/ to include/qobject/	2025-02-10 15:33:16 +01:00
raw-format.c	raw-format: Fix error message for invalid offset/size	2024-10-22 17:52:49 +02:00
rbd.c	qapi: Move include/qapi/qmp/ to include/qobject/	2025-02-10 15:33:16 +01:00
replication.c	Block layer patches	2025-02-10 13:25:36 -05:00
reqlist.c	block/reqlist: allow adding overlapping requests	2024-09-30 10:53:18 +03:00
snapshot-access.c	include: Rename sysemu/ -> system/	2024-12-20 17:44:56 +01:00
snapshot.c	block: Zero block driver state before reopening	2025-03-11 15:49:14 +01:00
ssh.c	qapi: Move include/qapi/qmp/ to include/qobject/	2025-02-10 15:33:16 +01:00
stream.c	qapi: Move include/qapi/qmp/ to include/qobject/	2025-02-10 15:33:16 +01:00
throttle-groups.c	include: Rename sysemu/ -> system/	2024-12-20 17:44:56 +01:00
throttle.c	block: Take graph lock for most of .bdrv_open	2023-11-08 17:56:18 +01:00
trace-events	nbd/client: Accept 64-bit block status chunks	2023-10-05 11:02:08 -05:00
trace.h	trace: switch position of headers to what Meson requires	2020-08-21 06:18:24 -04:00
vdi.c	include: Rename sysemu/ -> system/	2024-12-20 17:44:56 +01:00
vhdx-endian.c	Include qemu-common.h exactly where needed	2019-06-12 13:20:20 +02:00
vhdx-log.c	vhdx: Take locks for accessing bs->file	2023-11-08 17:56:18 +01:00
vhdx.c	qapi: Move include/qapi/qmp/ to include/qobject/	2025-02-10 15:33:16 +01:00
vhdx.h	vhdx: Take locks for accessing bs->file	2023-11-08 17:56:18 +01:00
vmdk.c	qapi: Move include/qapi/qmp/ to include/qobject/	2025-02-10 15:33:16 +01:00
vpc.c	Block layer patches	2025-02-10 13:25:36 -05:00
vvfat.c	qapi: Move include/qapi/qmp/ to include/qobject/	2025-02-10 15:33:16 +01:00
win32-aio.c	aio: remove aio_disable_external() API	2023-05-30 17:37:26 +02:00
write-threshold.c	block: remove AioContext locking	2023-12-21 22:49:27 +01:00