Paolo Bonzini a7b7953d8d hw/audio/hda: fix memory leak on audio setup ... When SET_STREAM_FORMAT is called, the st->buft timer is overwritten, thus causing a memory leak. This was originally fixed in commit 816139ae6a5 ("hw/audio/hda: fix memory leak on audio setup", 2024-11-14) but that caused the audio to break in SPICE. Fortunately, a simpler fix is possible. The timer only needs to be reset, because the callback is always the same (st->output is set at realize time in hda_audio_init); call to timer_new_ns overkill. Replace it with timer_del and only initialize the timer once; for simplicity, do it even if use_timer is false. An even simpler fix would be to free the old time in hda_audio_setup(). However, it seems better to place the initialization of the timer close to that of st->ouput. Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Reviewed-by: Michael Tokarev <mjt@tls.msk.ru> Message-ID: <20241114125318.1707590-3-pbonzini@redhat.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> (cherry picked from commit 626b39006d) Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>		2024-11-18 19:29:56 +03:00
..
9pfs	9pfs: fix crash on 'Treaddir' request	2024-11-08 20:42:08 +03:00
acpi	hw/acpi: Fix ordering of BDF in Generic Initiator PCI Device Handle.	2024-11-06 15:01:58 +03:00
adc	aspeed/adc: Add AST2700 support	2024-07-21 07:46:38 +02:00
alpha	alpha: switch boards to "default y"	2024-05-03 15:47:47 +02:00
arm	docs: Fix some typos (found by typos) and grammar issues	2024-08-16 14:12:59 +01:00
audio	hw/audio/hda: fix memory leak on audio setup	2024-11-18 19:29:56 +03:00
avr	avr: switch boards to "default y"	2024-05-03 15:47:47 +02:00
block	hw/block/fdc-isa: Assert that isa_fdc_get_drive_max_chs() found something	2024-08-06 10:22:52 +02:00
char	hw/char/pl011: Use correct masks for IBRD and FBRD	2024-10-15 20:33:06 +03:00
core	hw/core/ptimer: fix timer zero period condition for freq > 1GHz	2024-08-12 11:40:16 +01:00
cpu	hw: Add a Kconfig switch for the TYPE_CPU_CLUSTER device	2024-04-25 12:48:12 +02:00
cris	cris: switch boards to "default y"	2024-05-03 15:47:47 +02:00
cxl	Misc HW patch queue	2024-07-24 15:39:43 +10:00
display	ui/win32: fix potential use-after-free with dbus shared memory	2024-10-16 11:15:04 +03:00
dma	hw/dma/xilinx_axidma: Use semicolon at end of statement, not comma	2024-08-20 00:38:48 +02:00
fsi	hw/fsi: Aspeed APB2OPB & On-chip peripheral bus	2024-02-01 08:33:18 +01:00
gpio	hw/gpio/aspeed: Add reg_table_count to AspeedGPIOClass	2024-07-02 07:52:43 +02:00
hppa	hw/hppa/machine: Replace g_memdup() by g_memdup2()	2024-05-08 19:42:45 +02:00
hyperv	kvm: move target-dependent interrupt routing out of kvm-all.c	2024-05-03 15:47:48 +02:00
i2c	hw/i2c/mpc_i2c: Fix mmio region size	2024-07-23 20:30:36 +02:00
i386	hw/i386/pc: Don't try to init PCI NICs if there is no PCI bus	2024-11-18 19:29:40 +03:00
ide	mac_dbdma: Remove leftover dma_memory_unmap calls	2024-09-25 21:05:07 +03:00
input	hw: arm: Remove use of tabs in some source files	2024-05-28 14:20:48 +01:00
intc	hw/intc/riscv_aplic: Check and update pending when write sourcecfg	2024-11-05 10:28:23 +03:00
ipack	hw/ipack: Constify VMState	2023-12-29 11:17:30 +11:00
ipmi	hw/ipmi: Constify VMState	2023-12-29 11:17:30 +11:00
isa	hw/isa/vt82c686: Turn "intr" irq into a named gpio	2024-07-16 20:04:08 +02:00
loongarch	hw/loongarch/virt: Add description for virt machine type	2024-09-26 13:15:03 +03:00
m68k	hw: skip registration of outdated versioned machine types	2024-07-02 06:58:37 +02:00
mem	hw/cxl/cxl-mailbox-utils: Add device DDR5 ECS control feature	2024-07-21 14:42:04 -04:00
microblaze	microblaze: switch boards to "default y"	2024-05-03 15:47:47 +02:00
mips	hw/mips/jazz: fix typo in in-built NIC alias	2024-09-28 07:35:30 +03:00
misc	hw/misc/stm32l4x5_rcc: Add validation for MCOPRE and MCOSEL values	2024-08-13 11:34:56 +01:00
net	vhost: Add VIRTIO_NET_F_RSC_EXT to vhost feature bits	2024-08-20 06:57:47 -04:00
nubus	hw/nubus/virtio-mmio: Fix missing ERRP_GUARD() in realize handler	2024-07-23 22:34:09 +02:00
nvme	hw/nvme: fix handling of over-committed queues	2024-11-08 20:41:36 +03:00
nvram	hw/nvram: Add BCM2835 OTP device	2024-07-01 12:48:55 +01:00
openrisc	kconfig: express dependency of individual boards on libfdt	2024-05-10 15:45:15 +02:00
pci	softmmu: Support concurrent bounce buffers	2024-09-25 21:04:10 +03:00
pci-bridge	Misc HW patch queue	2024-04-25 09:43:29 -07:00
pci-host	hw/pci-host/gt64120: Reset config registers during RESET phase	2024-08-06 16:24:14 +02:00
pcmcia	hw/pcmcia/pxa2xx: Inline pxa2xx_pcmcia_init()	2023-10-27 12:48:57 +01:00
ppc	ppc/pnv: ADU fix possible buffer overrun with invalid size	2024-11-05 18:57:35 +03:00
remote	hw/remote/message.c: Don't directly invoke DeviceClass:reset	2024-08-20 00:38:48 +02:00
riscv	Revert "hw/riscv/virt.c: imsics DT: add '#msi-cells'"	2024-08-19 14:34:49 +10:00
rtc	docs: Correct Loongarch -> LoongArch	2024-07-23 20:30:36 +02:00
rx	kconfig: express dependency of individual boards on libfdt	2024-05-10 15:45:15 +02:00
s390x	virtio: features,fixes	2024-07-03 20:54:17 -07:00
scsi	scsi-disk: Always report RESERVATION_CONFLICT to guest	2024-08-06 20:12:39 +02:00
sd	hw/sd/sdcard: Fix calculation of size when using eMMC boot partitions	2024-11-05 19:14:12 +03:00
sensor	hw, target: Add ResetType argument to hold and exit phase methods	2024-04-25 10:21:06 +01:00
sh4	Revert "hw/sh4/r2d: Realize IDE controller before accessing it"	2024-10-22 20:24:35 +03:00
smbios	smbios: make memory device size configurable per Machine	2024-07-22 20:15:41 -04:00
sparc	sparc: switch boards to "default y"	2024-05-03 15:47:48 +02:00
sparc64	qemu-sparc queue	2024-05-06 10:19:56 -07:00
ssi	hw/ssi/pnv_spi: Fixes Coverity CID 1558831	2024-11-05 18:59:01 +03:00
timer	hpet: avoid timer storms on periodic timers	2024-07-22 19:19:44 +02:00
tpm	hw/tpm: Remove HOST_PAGE_ALIGN from tpm_ppi_init	2024-02-29 11:35:36 -10:00
tricore	tricore: switch boards to "default y"	2024-05-03 15:47:48 +02:00
ufs	hw/ufs: Fix mcq register range check logic	2024-07-14 17:11:21 +09:00
usb	hw/usb/u2f-passthru: Get rid of qemu_open_old()	2024-07-17 14:04:15 +03:00
vfio	vfio/container: Fix container object destruction	2024-11-18 19:29:41 +03:00
virtio	virtio-pci: Fix the use of an uninitialized irqfd	2024-08-20 06:57:47 -04:00
watchdog	aspeed/wdt: Add AST2700 support	2024-06-16 21:08:54 +02:00
xen	xen: mapcache: Fix unmapping of first entries in buckets	2024-07-12 00:17:36 +02:00
xenpv	hw/xen: Register framebuffer backend via xen_backend_init()	2024-06-04 11:53:43 +02:00
xtensa	hw/xtensa: require libfdt	2024-05-10 15:45:15 +02:00
Kconfig	hw: Fix problem with the A*MPCORE switches in the Kconfig files	2024-04-25 12:48:12 +02:00
meson.build	hw/rdma: Remove deprecated pvrdma device and rdmacm-mux helper	2024-04-24 16:03:38 +02:00