qemu/target/i386/kvm
Markus Armbruster a5c051b2cf i386: Never free migration blocker objects instead of sometimes
invtsc_mig_blocker has static storage duration.  When a CPU with
certain features is initialized, and invtsc_mig_blocker is still null,
we add a migration blocker and store it in invtsc_mig_blocker.

The object is freed when migrate_add_blocker() fails, leaving
invtsc_mig_blocker dangling.  It is not freed on later failures.

Same for hv_passthrough_mig_blocker and hv_no_nonarch_cs_mig_blocker.

All failures are actually fatal, so whether we free or not doesn't
really matter, except as bad examples to be copied / imitated.

Clean this up in a minimal way: never free these blocker objects.

Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20210720125408.387910-7-armbru@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
2021-08-26 17:15:28 +02:00
..
hyperv-proto.h i386: Hyper-V SynIC requires POST_MESSAGES/SIGNAL_EVENTS privileges 2021-07-13 09:13:29 -04:00
hyperv-stub.c i386: move kvm accel files into kvm/ 2020-12-16 14:06:52 -05:00
hyperv.c i386: move kvm accel files into kvm/ 2020-12-16 14:06:52 -05:00
hyperv.h i386: move kvm accel files into kvm/ 2020-12-16 14:06:52 -05:00
kvm-cpu.c i386: do not call cpudef-only models functions for max, host, base 2021-07-23 15:47:13 +02:00
kvm-cpu.h i386: split cpu accelerators from cpu.c, using AccelCPUClass 2021-05-10 15:41:49 -04:00
kvm-stub.c i386: expand Hyper-V features during CPU feature expansion time 2021-07-13 09:13:29 -04:00
kvm.c i386: Never free migration blocker objects instead of sometimes 2021-08-26 17:15:28 +02:00
kvm_i386.h i386: expand Hyper-V features during CPU feature expansion time 2021-07-13 09:13:29 -04:00
meson.build i386: split cpu accelerators from cpu.c, using AccelCPUClass 2021-05-10 15:41:49 -04:00
trace-events docs: fix references to docs/devel/tracing.rst 2021-06-02 06:51:09 +02:00
trace.h i386: move kvm accel files into kvm/ 2020-12-16 14:06:52 -05:00