motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-12-25 08:58:36 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions
qemu/hw/remote
History
Markus Armbruster 96ac971933 multi-process: Fix pci_proxy_dev_realize() error handling 
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL.  Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.

pci_proxy_dev_realize() is wrong that way: it passes @errp to
qio_channel_new_fd() without checking for failure.  If it runs into
another failure, it trips error_setv()'s assertion.

Fix it to check for failure properly.

Fixes: 9f8112073a
Cc: Elena Ufimtseva <elena.ufimtseva@oracle.com>
Cc: Jagannathan Raman <jag.raman@oracle.com>
Cc: John G Johnson <john.g.johnson@oracle.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20210720125408.387910-5-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Jagannathan Raman <jag.raman@oracle.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
2021-08-26 17:15:28 +02:00
..
iohub.c Do not include hw/boards.h if it's not really necessary 2021-05-02 17:24:51 +02:00
Kconfig multi-process: setup PCI host bridge for remote device 2021-02-10 09:23:22 +00:00
machine.c Do not include exec/address-spaces.h if it's not really necessary 2021-05-02 17:24:51 +02:00
memory.c remote/memory: Replace share parameter with ram_flags 2021-07-20 15:34:20 -04:00
meson.build multi-process: create IOHUB object to handle irq 2021-02-10 09:23:28 +00:00
message.c multi-process: perform device reset in the remote process 2021-02-10 09:23:28 +00:00
mpqemu-link.c multi-process: Avoid logical AND of mutually exclusive tests 2021-05-13 18:15:32 +02:00
proxy-memory-listener.c Do not include exec/address-spaces.h if it's not really necessary 2021-05-02 17:24:51 +02:00
proxy.c multi-process: Fix pci_proxy_dev_realize() error handling 2021-08-26 17:15:28 +02:00
remote-obj.c multi-process: Associate fd of a PCIDevice with its object 2021-02-10 09:23:28 +00:00
trace-events multi-process: define MPQemuMsg format and transmission functions 2021-02-10 09:23:28 +00:00
trace.h multi-process: define MPQemuMsg format and transmission functions 2021-02-10 09:23:28 +00:00