Andrey Shumilin 65b44e55e4 hw/intc/arm_gic: Fix handling of NS view of GICC_APR<n> ... In gic_cpu_read() and gic_cpu_write(), we delegate the handling of reading and writing the Non-Secure view of the GICC_APR<n> registers to functions gic_apr_ns_view() and gic_apr_write_ns_view(). Unfortunately we got the order of the arguments wrong, swapping the CPU number and the register number (which the compiler doesn't catch because they're both integers). Most guests probably didn't notice this bug because directly accessing the APR registers is typically something only done by firmware when it is doing state save for going into a sleep mode. Correct the mismatched call arguments. Found by Linux Verification Center (linuxtesting.org) with SVACE. Cc: qemu-stable@nongnu.org Fixes: 51fd06e0ee ("hw/intc/arm_gic: Fix handling of GICC_APR<n>, GICC_NSAPR<n> registers") Signed-off-by: Andrey Shumilin <shum.sdl@nppct.ru> [PMM: Rewrote commit message] Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Alex Bennée<alex.bennee@linaro.org> (cherry picked from commit daafa78b29) Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>		2024-05-30 17:13:24 +03:00
..
9pfs	* configure: use a native non-cross compiler for linux-user	2024-01-04 19:55:20 +00:00
acpi	hmat acpi: Fix out of bounds access due to missing use of indirection	2024-03-12 17:59:46 -04:00
adc	hw/adc: Constify VMState	2023-12-29 11:17:30 +11:00
alpha	hw/alpha/dp264: use pci_init_nic_devices()	2024-02-02 16:23:47 +00:00
arm	hw/arm/npcm7xx: Store derivative OTP fuse key in little endian	2024-05-02 13:17:18 +03:00
audio	hw/audio/virtio-snd: Remove unused assignment	2024-04-10 11:07:37 +02:00
avr	hw/avr/atmega: Fix wrong initial value of stack pointer	2023-11-28 14:27:12 +01:00
block	hw/pflash: fix block write start	2024-05-27 07:37:34 +03:00
char	hw/char/virtio-serial-bus: Protect from DMA re-entrancy bugs	2024-04-10 09:09:33 +02:00
core	hw/core/machine: move compatibility flags for VirtIO-net USO to machine 8.1	2024-05-27 07:37:34 +03:00
cpu	target/arm: Move GTimer definitions to new 'gtimer.h' header	2024-01-26 11:30:49 +00:00
cris	hw/net/etraxfs-eth: use qemu_configure_nic_device()	2024-02-02 16:23:47 +00:00
cxl	hw/cxl/cxl-host: Fix missing ERRP_GUARD() in cxl_fixed_memory_window_config()	2024-03-12 17:56:55 -04:00
display	hw/display/virtio-gpu: Protect from DMA re-entrancy bugs	2024-04-10 09:09:33 +02:00
dma	hw/dmax/xlnx_dpdma: fix handling of address_extension descriptor fields	2024-05-02 13:16:29 +03:00
fsi	hw/fsi: Aspeed APB2OPB & On-chip peripheral bus	2024-02-01 08:33:18 +01:00
gpio	* Fix timeouts in Travis-CI jobs	2024-03-25 14:19:42 +00:00
hppa	hw/hppa: do not require CONFIG_USB	2024-02-27 09:37:13 +01:00
hyperv	vmbus: Print a warning when enabled without the recommended set of features	2024-03-08 14:18:56 +01:00
i2c	hw/i2c: Implement Broadcom Serial Controller (BSC)	2024-03-05 13:22:55 +00:00
i386	* lsi53c895a: fix assertion failure with invalid Block Move	2024-04-03 12:52:03 +01:00
ide	hw/ide/ahci: Rename ahci_internal.h to ahci-internal.h	2024-03-11 22:09:42 +01:00
input	hw/input/pckbd: Open-code i8042_setup_a20_line() wrapper	2024-02-22 12:47:35 +01:00
intc	hw/intc/arm_gic: Fix handling of NS view of GICC_APR<n>	2024-05-30 17:13:24 +03:00
ipack	hw/ipack: Constify VMState	2023-12-29 11:17:30 +11:00
ipmi	hw/ipmi: Constify VMState	2023-12-29 11:17:30 +11:00
isa	hw/isa/vt82c686: Keep track of PIRQ/PINT pins separately	2024-04-15 13:07:11 +02:00
loongarch	hw/loongarch/virt: Fix FDT memory node address width	2024-05-27 07:50:35 +03:00
m68k	virt: set the CPU type in BOOTINFO	2024-03-11 09:38:08 +01:00
mem	hw/mem/cxl_type3: Fix missing ERRP_GUARD() in ct3_realize()	2024-03-12 17:56:55 -04:00
microblaze	hw/microblaze: Do not allow xlnx-zynqmp-pmu-soc to be created by the user	2024-03-25 09:57:43 +01:00
mips	mips: do not list individual devices from configs/	2024-03-08 15:51:22 +01:00
misc	hw/misc/applesmc: Fix memory leak in reset() handler	2024-04-10 09:09:34 +02:00
net	hw/net/net_tx_pkt: Fix overrun in update_sctp_checksum()	2024-04-10 10:43:54 +02:00
nios2	target/nios2: Deprecate the Nios II architecture	2023-11-23 14:10:04 +00:00
nubus	hw/nubus: add nubus-virtio-mmio device	2024-02-27 09:36:39 +01:00
nvme	hw/nvme: fix -Werror=maybe-uninitialized	2024-04-02 16:15:07 +02:00
nvram	hw/nvram/mac_nvram: Report failure to write data	2024-03-25 10:41:01 +00:00
openrisc	hw/openrisc/openrisc_sim: use qemu_create_nic_device()	2024-02-02 16:23:47 +00:00
pci	virtio,pc,pci: features, cleanups, fixes	2024-03-13 15:11:53 +00:00
pci-bridge	virtio,pc,pci: features, cleanups, fixes	2024-03-13 15:11:53 +00:00
pci-host	hw/pci-host/ppc440_pcix: Do not expose a bridge device on PCI bus	2024-04-15 13:07:15 +02:00
pcmcia	hw/pcmcia/pxa2xx: Inline pxa2xx_pcmcia_init()	2023-10-27 12:48:57 +01:00
ppc	hw/ppc/spapr: Include missing 'sysemu/tcg.h' header	2024-03-30 18:50:23 +10:00
rdma	hw/rdma/vmw/pvrdma_cmd: Use correct struct in query_port()	2023-10-21 15:00:22 +03:00
remote	hw/remote/vfio-user: Fix config space access byte order	2024-05-10 13:20:20 +03:00
riscv	target/riscv/kvm: fix timebase-frequency when using KVM acceleration	2024-03-22 15:41:01 +10:00
rtc	hw/rtc/sun4v-rtc: Relicense to GPLv2-or-later	2024-03-07 12:54:56 +00:00
rx	hw/rx/rx62n: Only call qdev_get_gpio_in() when necessary	2024-02-15 16:58:46 +01:00
s390x	hw/core: Declare CPUArchId::cpu as CPUState instead of Object	2024-03-12 11:46:16 +01:00
scsi	esp.c: remove explicit setting of DRQ within ESP state machine	2024-04-04 15:17:53 +01:00
sd	hw/sd/sdhci: Do not update TRNMOD when Command Inhibit (DAT) is set	2024-04-10 09:09:34 +02:00
sensor	hw/sensor: Constify VMState	2023-12-30 07:38:06 +11:00
sh4	hw/usb: extract sysbus-ohci to a separate file	2024-02-27 09:37:25 +01:00
smbios	hw/smbios: add stub for smbios_get_table_legacy()	2024-03-26 14:32:54 +01:00
sparc	hw/sparc/leon3: Fix wrong usage of DO_UPCAST macro	2024-02-22 12:47:40 +01:00
sparc64	sun4u: remap ebus BAR0 to use unassigned_io_ops instead of alias to PCI IO space	2024-03-11 22:10:18 +01:00
ssi	aspeed/smc: Only wire flash devices at reset	2024-03-19 11:58:15 +01:00
timer	misc: pxa2xx_timer: replace qemu_system_reset_request() call with watchdog_perform_action()	2024-02-27 13:01:41 +00:00
tpm	hw/tpm: Remove HOST_PAGE_ALIGN from tpm_ppi_init	2024-02-29 11:35:36 -10:00
tricore	hw/tricore/testboard: Use qdev_new() instead of QOM basic API	2024-02-22 12:47:40 +01:00
ufs	hw/ufs: Fix buffer overflow bug	2024-05-02 13:03:05 +03:00
usb	usb-storage: Fix BlockConf defaults	2024-04-16 11:50:52 +01:00
vfio	vfio/iommufd: Fix memory leak	2024-03-19 11:56:37 +01:00
virtio	virtio: bugfix	2024-04-15 13:35:32 +01:00
watchdog	hw/watchdog: Constify VMState	2023-12-30 07:38:06 +11:00
xen	Xen queue:	2024-03-12 21:32:31 +00:00
xenpv	hw/xen: use qemu_create_nic_bus_devices() to instantiate Xen NICs	2024-02-02 16:23:47 +00:00
xtensa	hw/xtensa/xtfpga: use qemu_create_nic_device()	2024-02-02 16:23:47 +00:00
Kconfig	hw/fsi: Introduce IBM's Local bus	2024-02-01 08:13:30 +01:00
meson.build	hw/fsi: Introduce IBM's Local bus	2024-02-01 08:13:30 +01:00