mirror of
https://github.com/Motorhead1991/qemu.git
synced 2025-08-02 07:13:54 -06:00
![]() build_cpus_aml() is architecture independent but needs to create architecture- specific CPU AML. So far this was achieved by using a virtual method from TYPE_ACPI_DEVICE_IF. However, build_cpus_aml() would resolve this interface from global (!) state. This makes it quite incomprehensible where this interface comes from (TYPE_PIIX4_PM?, TYPE_ICH9_LPC_DEVICE?, TYPE_ACPI_GED_X86?) an can lead to crashes when the generic code is ported to new architectures. So far, build_cpus_aml() is only called in architecture-specific code -- and only in x86. We can therefore simply pass pc_madt_cpu_entry() as callback to build_cpus_aml(). This is the same callback that would be used through TYPE_ACPI_DEVICE_IF. Signed-off-by: Bernhard Beschow <shentey@gmail.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Message-Id: <20230908084234.17642-3-shentey@gmail.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> |
||
---|---|---|
.. | ||
acpi-defs.h | ||
acpi.h | ||
acpi_aml_interface.h | ||
acpi_dev_interface.h | ||
aml-build.h | ||
bios-linker-loader.h | ||
cpu.h | ||
cpu_hotplug.h | ||
cxl.h | ||
erst.h | ||
generic_event_device.h | ||
ghes.h | ||
ich9.h | ||
ich9_tco.h | ||
ipmi.h | ||
memory_hotplug.h | ||
pc-hotplug.h | ||
pci.h | ||
pcihp.h | ||
piix4.h | ||
tpm.h | ||
utils.h | ||
vmgenid.h |