mirror of
https://github.com/Motorhead1991/qemu.git
synced 2025-07-27 04:13:53 -06:00
5a7b6029c1
On arm/virt platform, Chen Xiang reported a Guest crash while
attempting the below steps,
1. Launch the Guest with nvdimm=on
2. Hot-add a NVDIMM dev
3. Reboot
4. Guest boots fine.
5. Reboot again.
6. Guest boot fails.
QEMU_EFI reports the below error:
ProcessCmdAddPointer: invalid pointer value in "etc/acpi/tables"
OnRootBridgesConnected: InstallAcpiTables: Protocol Error
Debugging shows that on first reboot(after hot adding NVDIMM),
Qemu updates the etc/table-loader len,
qemu_ram_resize()
fw_cfg_modify_file()
fw_cfg_modify_bytes_read()
And in fw_cfg_modify_bytes_read() we set the "callback_opaque" for
the key entry to NULL. Because of this, on the second reboot,
virt_acpi_build_update() is called with a NULL "build_state" and
returns without updating the ACPI tables. This seems to be
upsetting the firmware.
To fix this, don't change the callback_opaque in fw_cfg_modify_bytes_read().
Fixes:
|
||
|---|---|---|
| .. | ||
| bcm2835_otp.c | ||
| chrp_nvram.c | ||
| ds1225y.c | ||
| eeprom93xx.c | ||
| eeprom_at24c.c | ||
| fw_cfg-acpi.c | ||
| fw_cfg-interface.c | ||
| fw_cfg.c | ||
| Kconfig | ||
| mac_nvram.c | ||
| meson.build | ||
| npcm7xx_otp.c | ||
| nrf51_nvm.c | ||
| spapr_nvram.c | ||
| trace-events | ||
| trace.h | ||
| xlnx-bbram.c | ||
| xlnx-efuse-crc.c | ||
| xlnx-efuse.c | ||
| xlnx-versal-efuse-cache.c | ||
| xlnx-versal-efuse-ctrl.c | ||
| xlnx-zynqmp-efuse.c | ||