motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-12-30 03:00:29 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions
qemu/migration
History
Markus Armbruster 193227f9e5 error: Use error_report_err() instead of monitor_printf() 
Both error_report_err() and monitor_printf() print to the same
destination when monitor_printf() is used correctly, i.e. within an
HMP monitor.  Elsewhere, monitor_printf() does nothing, while
error_report_err() reports to stderr.

Most changed functions are HMP command handlers.  These should only
run within an HMP monitor.  The one exception is bdrv_password_cb(),
which should also only run within an HMP monitor.

Four command handlers prefix the error message with the command name:
balloon, migrate_set_capability, migrate_set_parameter, migrate.
Pointless, drop.

Unlike monitor_printf(), error_report_err() uses the error whole
instead of just its message obtained with error_get_pretty().  This
avoids suppressing its hint (see commit 50b7b00).  Example:

    (qemu) device_add ivshmem,id=666
    Parameter 'id' expects an identifier
    Identifiers consist of letters, digits, '-', '.', '_', starting with a letter.
    Try "help device_add" for more information

The "Identifiers consist of..." line is new with this patch.

Coccinelle semantic patch:

    @@
    expression M, E;
    @@
    -    monitor_printf(M, "%s\n", error_get_pretty(E));
    -    error_free(E);
    +    error_report_err(E);
    @r1@
    expression M, E;
    format F;
    position p;
    @@
    -    monitor_printf(M, "...%@F@\n", error_get_pretty(E));@p
    -    error_free(E);
    +    error_report_err(E);
    @script:python@
	p << r1.p;
    @@
    print "%s:%s:%s: prefix dropped" % (p[0].file, p[0].line, p[0].column)

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <1450452927-8346-4-git-send-email-armbru@redhat.com>
2016-01-13 15:16:16 +01:00
..
block.c block-migration: limit the memory usage 2015-11-25 15:27:28 +01:00
exec.c Change qemu_set_fd_handler2(..., NULL, ...) to qemu_set_fd_handler 2015-06-12 13:26:21 +01:00
fd.c Change qemu_set_fd_handler2(..., NULL, ...) to qemu_set_fd_handler 2015-06-12 13:26:21 +01:00
Makefile.objs postcopy: OS support test 2015-11-10 15:00:26 +01:00
migration.c qapi: Don't let implicit enum MAX member collide 2015-12-17 08:21:28 +01:00
postcopy-ram.c Assume madvise for (no)hugepage works 2015-11-25 15:27:28 +01:00
qemu-file-buf.c coroutine: move into libqemuutil.a library 2015-10-20 14:59:04 +01:00
qemu-file-internal.h Split struct QEMUFile out 2014-12-16 17:47:36 +05:30
qemu-file-stdio.c coroutine: move into libqemuutil.a library 2015-10-20 14:59:04 +01:00
qemu-file-unix.c migration: Clean up use of g_poll() in socket_writev_buffer() 2015-12-03 00:03:00 +01:00
qemu-file.c Return path: Open a return path on QEMUFile for sockets 2015-11-10 14:51:49 +01:00
ram.c Fix xbzrle vs last_sent_block update 2015-12-11 12:51:27 +00:00
rdma.c migration: Make 32bit linux compile with RDMA 2015-11-12 17:52:29 +01:00
savevm.c error: Use error_report_err() instead of monitor_printf() 2016-01-13 15:16:16 +01:00
tcp.c Change qemu_set_fd_handler2(..., NULL, ...) to qemu_set_fd_handler 2015-06-12 13:26:21 +01:00
unix.c Change qemu_set_fd_handler2(..., NULL, ...) to qemu_set_fd_handler 2015-06-12 13:26:21 +01:00
vmstate.c vmstate: Create optional sections 2015-07-07 14:54:52 +02:00
xbzrle.c Start migrating migration code into a migration directory 2014-12-16 17:47:36 +05:30