mirror of
https://github.com/Motorhead1991/qemu.git
synced 2025-07-27 04:13:53 -06:00
bc85aae420
Live migration should be terminated if the vhost-user backend crashes before the migration completes. Specifically, since the vhost device will be stopped when VM is stopped before the end of the live migration, in current implementation if the backend crashes, vhost-user device set_status() won't return failure, live migration won't perceive the disconnection between QEMU and the backend. When the VM is migrated to the destination, the inflight IO will be resubmitted, and if the IO was completed out of order before, it will cause IO error. To fix this issue: 1. Add the return value to set_status() for VirtioDeviceClass. a. For the vhost-user device, return failure when the backend crashes. b. For other virtio devices, always return 0. 2. Return failure if vhost_dev_stop() failed for vhost-user device. If QEMU loses connection with the vhost-user backend, virtio set_status() can return failure to the upper layer, migration_completion() can handle the error, terminate the live migration, and restore the VM, so that inflight IO can be completed normally. Signed-off-by: Haoqian He <haoqian.he@smartx.com> Message-Id: <20250416024729.3289157-4-haoqian.he@smartx.com> Tested-by: Lei Yang <leiyang@redhat.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
53 lines
1.4 KiB
C
53 lines
1.4 KiB
C
/*
|
|
* Parent class for vhost-vsock devices
|
|
*
|
|
* Copyright 2015-2020 Red Hat, Inc.
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or
|
|
* (at your option) any later version. See the COPYING file in the
|
|
* top-level directory.
|
|
*/
|
|
|
|
#ifndef QEMU_VHOST_VSOCK_COMMON_H
|
|
#define QEMU_VHOST_VSOCK_COMMON_H
|
|
|
|
#include "qapi/qapi-types-common.h"
|
|
#include "hw/virtio/virtio.h"
|
|
#include "hw/virtio/vhost.h"
|
|
#include "qom/object.h"
|
|
|
|
#define TYPE_VHOST_VSOCK_COMMON "vhost-vsock-common"
|
|
OBJECT_DECLARE_SIMPLE_TYPE(VHostVSockCommon, VHOST_VSOCK_COMMON)
|
|
|
|
enum {
|
|
VHOST_VSOCK_SAVEVM_VERSION = 0,
|
|
|
|
VHOST_VSOCK_QUEUE_SIZE = 128,
|
|
};
|
|
|
|
struct VHostVSockCommon {
|
|
VirtIODevice parent;
|
|
|
|
struct vhost_virtqueue vhost_vqs[2];
|
|
struct vhost_dev vhost_dev;
|
|
|
|
VirtQueue *event_vq;
|
|
VirtQueue *recv_vq;
|
|
VirtQueue *trans_vq;
|
|
|
|
QEMUTimer *post_load_timer;
|
|
|
|
/* features */
|
|
OnOffAuto seqpacket;
|
|
};
|
|
|
|
int vhost_vsock_common_start(VirtIODevice *vdev);
|
|
int vhost_vsock_common_stop(VirtIODevice *vdev);
|
|
int vhost_vsock_common_pre_save(void *opaque);
|
|
int vhost_vsock_common_post_load(void *opaque, int version_id);
|
|
void vhost_vsock_common_realize(VirtIODevice *vdev);
|
|
void vhost_vsock_common_unrealize(VirtIODevice *vdev);
|
|
uint64_t vhost_vsock_common_get_features(VirtIODevice *vdev, uint64_t features,
|
|
Error **errp);
|
|
|
|
#endif /* QEMU_VHOST_VSOCK_COMMON_H */
|