mirror of
https://github.com/Motorhead1991/qemu.git
synced 2025-07-27 04:13:53 -06:00
5b87a07e76
We have some users of the PL011 struct which embed it directly into their own state structs. This means that the Rust version of the device must have a state struct that is the same size or smaller than the C struct. In commit9b642097d6("rust: pl011: switch to safe chardev operation") the Rust PL011 state struct changed from having a bindings::CharBackend to a chardev::CharBackend, which made it grow larger than the C version. This results in an assertion at startup when QEMU was built with Rust enabled: $ qemu-system-arm -M raspi2b -display none ERROR:../../qom/object.c:562:object_initialize_with_type: assertion failed: (size >= type->instance_size) The long-term better approach to this problem would be to move our C device code patterns away from "embed a struct" and (back) to "have a pointer to the device", so we can make the C PL011State struct a private implementation detail rather than exposed to its users. For the short term, add a padding field at the end of the C struct so it's big enough that the Rust state struct can fit. Fixes:9b642097d6("rust: pl011: switch to safe chardev operation") Reviewed-by: Zhao Liu <zhao1.liu@intel.com> Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Link: https://lore.kernel.org/r/20250321112523.1774131-3-peter.maydell@linaro.org Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
64 lines
1.7 KiB
C
64 lines
1.7 KiB
C
/*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms and conditions of the GNU General Public License,
|
|
* version 2 or later, as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope it will be useful, but WITHOUT
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
|
|
* more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along with
|
|
* this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef HW_PL011_H
|
|
#define HW_PL011_H
|
|
|
|
#include "hw/sysbus.h"
|
|
#include "chardev/char-fe.h"
|
|
#include "qom/object.h"
|
|
|
|
#define TYPE_PL011 "pl011"
|
|
OBJECT_DECLARE_SIMPLE_TYPE(PL011State, PL011)
|
|
|
|
/* This shares the same struct (and cast macro) as the base pl011 device */
|
|
#define TYPE_PL011_LUMINARY "pl011_luminary"
|
|
|
|
/* Depth of UART FIFO in bytes, when FIFO mode is enabled (else depth == 1) */
|
|
#define PL011_FIFO_DEPTH 16
|
|
|
|
struct PL011State {
|
|
SysBusDevice parent_obj;
|
|
|
|
MemoryRegion iomem;
|
|
uint32_t flags;
|
|
uint32_t lcr;
|
|
uint32_t rsr;
|
|
uint32_t cr;
|
|
uint32_t dmacr;
|
|
uint32_t int_enabled;
|
|
uint32_t int_level;
|
|
uint32_t read_fifo[PL011_FIFO_DEPTH];
|
|
uint32_t ilpr;
|
|
uint32_t ibrd;
|
|
uint32_t fbrd;
|
|
uint32_t ifl;
|
|
int read_pos;
|
|
int read_count;
|
|
int read_trigger;
|
|
CharBackend chr;
|
|
qemu_irq irq[6];
|
|
Clock *clk;
|
|
bool migrate_clk;
|
|
const unsigned char *id;
|
|
/*
|
|
* Since some users embed this struct directly, we must
|
|
* ensure that the C struct is at least as big as the Rust one.
|
|
*/
|
|
uint8_t padding_for_rust[16];
|
|
};
|
|
|
|
DeviceState *pl011_create(hwaddr addr, qemu_irq irq, Chardev *chr);
|
|
|
|
#endif
|