qemu/target/mips/tcg/system
Richard Henderson 256ba7715b target/mips: Simplify and fix update_pagemask
When update_pagemask was split from helper_mtc0_pagemask,
we failed to actually write to the new parameter but continue
to write to env->CP0_PageMask.  Thus the use within
page_table_walk_refill modifies cpu state and not the local
variable as expected.

Simplify by renaming to compute_pagemask and returning the
value directly.  No need for either env or pointer return.

Fixes: 074cfcb4da ("target/mips: Implement hardware page table walker for MIPS32")
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20250328175526.368121-4-richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Cc: qemu-stable@nongnu.org
2025-03-31 21:32:43 +02:00
..
cp0_helper.c target/mips: Simplify and fix update_pagemask 2025-03-31 21:32:43 +02:00
lcsr_helper.c include: Rename sysemu/ -> system/ 2024-12-20 17:44:56 +01:00
meson.build include: Rename sysemu/ -> system/ 2024-12-20 17:44:56 +01:00
mips-semi.c target/mips: Remove tswap() calls in semihosting uhi_fstat_cb() 2024-12-20 17:44:57 +01:00
semihosting-stub.c licenses: Remove SPDX tags not being license identifier for Linaro 2025-01-30 13:01:22 +03:00
special_helper.c accel/tcg: Move tcg_cflags_has/set() to 'exec/translation-block.h' 2024-12-20 17:44:57 +01:00
tlb_helper.c target/mips: Simplify and fix update_pagemask 2025-03-31 21:32:43 +02:00