mirror of
https://github.com/Motorhead1991/qemu.git
synced 2025-12-25 00:48:36 -07:00
5325cc34a2
The object_property_set_FOO() setters take property name and value in
an unusual order:
void object_property_set_FOO(Object *obj, FOO_TYPE value,
const char *name, Error **errp)
Having to pass value before name feels grating. Swap them.
Same for object_property_set(), object_property_get(), and
object_property_parse().
Convert callers with this Coccinelle script:
@@
identifier fun = {
object_property_get, object_property_parse, object_property_set_str,
object_property_set_link, object_property_set_bool,
object_property_set_int, object_property_set_uint, object_property_set,
object_property_set_qobject
};
expression obj, v, name, errp;
@@
- fun(obj, v, name, errp)
+ fun(obj, name, v, errp)
Chokes on hw/arm/musicpal.c's lcd_refresh() with the unhelpful error
message "no position information". Convert that one manually.
Fails to convert hw/arm/armsse.c, because Coccinelle gets confused by
ARMSSE being used both as typedef and function-like macro there.
Convert manually.
Fails to convert hw/rx/rx-gdbsim.c, because Coccinelle gets confused
by RXCPU being used both as typedef and function-like macro there.
Convert manually. The other files using RXCPU that way don't need
conversion.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200707160613.848843-27-armbru@redhat.com>
[Straightforwad conflict with commit
|
||
|---|---|---|
| .. | ||
| translate | ||
| arch_dump.c | ||
| compat.c | ||
| cpu-models.c | ||
| cpu-models.h | ||
| cpu-param.h | ||
| cpu-qom.h | ||
| cpu.c | ||
| cpu.h | ||
| dfp_helper.c | ||
| excp_helper.c | ||
| fpu_helper.c | ||
| gdbstub.c | ||
| helper.h | ||
| helper_regs.h | ||
| int_helper.c | ||
| internal.h | ||
| kvm-stub.c | ||
| kvm.c | ||
| kvm_ppc.h | ||
| machine.c | ||
| Makefile.objs | ||
| mem_helper.c | ||
| mfrom_table.inc.c | ||
| mfrom_table_gen.c | ||
| misc_helper.c | ||
| mmu-book3s-v3.c | ||
| mmu-book3s-v3.h | ||
| mmu-hash32.c | ||
| mmu-hash32.h | ||
| mmu-hash64.c | ||
| mmu-hash64.h | ||
| mmu-radix64.c | ||
| mmu-radix64.h | ||
| mmu_helper.c | ||
| monitor.c | ||
| timebase_helper.c | ||
| trace-events | ||
| translate.c | ||
| translate_init.inc.c | ||
| user_only_helper.c | ||