qemu/tests/libqos
John Snow 6100ddb0f9 qtest/ahci: Store hba_base in AHCIQState
Store the HBA memory base address in the new state object, to simplify
function prototypes and encourage a more functional testing style.

This causes a lot of churn, but this patch is as "simplified" as I could
get it to be. This patch is therefore fairly mechanical and straightforward:
Any case where we pass "hba_base" has been consolidated into the AHCIQState
object and we pass the one unified parameter.

Any case where we reference "ahci" and "hba_state" have been modified to use
"ahci->dev" for the PCIDevice and "ahci->hba_state" to get at the base memory
address, accordingly.

Notes:

 - A needless return is removed from start_ahci_device.

 - For ease of reviewing, this patch can be reproduced (mostly) by:
   # Replace (ahci, hba_base) prototypes with unified parameter
   's/(QPCIDevice \*ahci, void \*\?\*hba_base/(AHCIQState *ahci/'

   # Replace (ahci->dev, hba_base) calls with unified parameter
   's/(ahci->dev, &\?hba_base)/(ahci)/'

   # Replace calls to PCI config space using "ahci" with "ahci->dev"
   's/qpci_config_\(read\|write\)\(.\)(ahci,/qpci_config_\1\2(ahci->dev,/'

   After these, the remaining differences are easy to review by hand.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 1421698563-6977-9-git-send-email-jsnow@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2015-02-16 14:40:55 +00:00
..
ahci.h qtest/ahci: Store hba_base in AHCIQState 2015-02-16 14:40:55 +00:00
fw_cfg.c libqos: Generalize I/O-mapped fw_cfg 2013-07-18 13:27:47 -05:00
fw_cfg.h libqos: Generalize I/O-mapped fw_cfg 2013-07-18 13:27:47 -05:00
i2c-omap.c libqos: Relocate I2C files 2013-05-03 12:03:14 -05:00
i2c.c libqos: Relocate I2C files 2013-05-03 12:03:14 -05:00
i2c.h libqos: Relocate I2C files 2013-05-03 12:03:14 -05:00
libqos-pc.c libqos: add pc specific interface 2015-02-16 14:40:55 +00:00
libqos-pc.h libqos: add pc specific interface 2015-02-16 14:40:55 +00:00
libqos.c libqos: add pc specific interface 2015-02-16 14:40:55 +00:00
libqos.h libqos: add pc specific interface 2015-02-16 14:40:55 +00:00
malloc-pc.c libqos: Update QGuestAllocator to be opaque 2015-02-16 14:38:55 +00:00
malloc-pc.h libqos: Convert malloc-pc allocator to a generic allocator 2015-01-13 11:47:57 +00:00
malloc.c libqos: Update QGuestAllocator to be opaque 2015-02-16 14:38:55 +00:00
malloc.h libqos: Update QGuestAllocator to be opaque 2015-02-16 14:38:55 +00:00
pci-pc.c libqos: Add qpci_plug_device_test() and qpci_unplug_acpi_device_test() 2014-10-15 05:03:12 +02:00
pci-pc.h libqos: Fixes a small memory leak. 2014-08-15 18:03:13 +01:00
pci.c ahci: add test_pci_enable to ahci-test. 2014-09-22 11:39:40 +01:00
pci.h libqos: Add qpci_plug_device_test() and qpci_unplug_acpi_device_test() 2014-10-15 05:03:12 +02:00
usb.c tests: usb: Generic usb device hotplug 2014-10-15 05:03:13 +02:00
usb.h tests: usb: Generic usb device hotplug 2014-10-15 05:03:13 +02:00
virtio-pci.c libqos: Added EVENT_IDX support 2014-09-08 11:12:43 +01:00
virtio-pci.h libqos: Added MSI-X support 2014-09-08 11:12:43 +01:00
virtio.c libqos: use microseconds instead of iterations for virtio timeout 2014-09-29 17:31:11 +01:00
virtio.h libqos: use microseconds instead of iterations for virtio timeout 2014-09-29 17:31:11 +01:00