mirror of
https://github.com/Motorhead1991/qemu.git
synced 2025-08-04 00:03:54 -06:00
5325cc34a2
The object_property_set_FOO() setters take property name and value in
an unusual order:
void object_property_set_FOO(Object *obj, FOO_TYPE value,
const char *name, Error **errp)
Having to pass value before name feels grating. Swap them.
Same for object_property_set(), object_property_get(), and
object_property_parse().
Convert callers with this Coccinelle script:
@@
identifier fun = {
object_property_get, object_property_parse, object_property_set_str,
object_property_set_link, object_property_set_bool,
object_property_set_int, object_property_set_uint, object_property_set,
object_property_set_qobject
};
expression obj, v, name, errp;
@@
- fun(obj, v, name, errp)
+ fun(obj, name, v, errp)
Chokes on hw/arm/musicpal.c's lcd_refresh() with the unhelpful error
message "no position information". Convert that one manually.
Fails to convert hw/arm/armsse.c, because Coccinelle gets confused by
ARMSSE being used both as typedef and function-like macro there.
Convert manually.
Fails to convert hw/rx/rx-gdbsim.c, because Coccinelle gets confused
by RXCPU being used both as typedef and function-like macro there.
Convert manually. The other files using RXCPU that way don't need
conversion.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200707160613.848843-27-armbru@redhat.com>
[Straightforwad conflict with commit 2336172d9b "audio: set default
value for pcspk.iobase property" resolved]
46 lines
1.2 KiB
C
46 lines
1.2 KiB
C
/*
|
|
* QEMU Object Model - QObject wrappers
|
|
*
|
|
* Copyright (C) 2012 Red Hat, Inc.
|
|
*
|
|
* Author: Paolo Bonzini <pbonzini@redhat.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "qapi/error.h"
|
|
#include "qom/object.h"
|
|
#include "qom/qom-qobject.h"
|
|
#include "qapi/visitor.h"
|
|
#include "qapi/qobject-input-visitor.h"
|
|
#include "qapi/qobject-output-visitor.h"
|
|
|
|
void object_property_set_qobject(Object *obj,
|
|
const char *name, QObject *value,
|
|
Error **errp)
|
|
{
|
|
Visitor *v;
|
|
|
|
v = qobject_input_visitor_new(value);
|
|
object_property_set(obj, name, v, errp);
|
|
visit_free(v);
|
|
}
|
|
|
|
QObject *object_property_get_qobject(Object *obj, const char *name,
|
|
Error **errp)
|
|
{
|
|
QObject *ret = NULL;
|
|
Error *local_err = NULL;
|
|
Visitor *v;
|
|
|
|
v = qobject_output_visitor_new(&ret);
|
|
object_property_get(obj, name, v, &local_err);
|
|
if (!local_err) {
|
|
visit_complete(v, &ret);
|
|
}
|
|
error_propagate(errp, local_err);
|
|
visit_free(v);
|
|
return ret;
|
|
}
|