Maciej S. Szmigiero 3f2a05b31e target/i386: Reset TSCs of parked vCPUs too on VM reset ... Since commit 5286c36622 ("target/i386: properly reset TSC on reset") QEMU writes the special value of "1" to each online vCPU TSC on VM reset to reset it. However parked vCPUs don't get that handling and due to that their TSCs get desynchronized when the VM gets reset. This in turn causes KVM to turn off PVCLOCK_TSC_STABLE_BIT in its exported PV clock. Note that KVM has no understanding of vCPU being currently parked. Without PVCLOCK_TSC_STABLE_BIT the sched clock is marked unstable in the guest's kvm_sched_clock_init(). This causes a performance regressions to show in some tests. Fix this issue by writing the special value of "1" also to TSCs of parked vCPUs on VM reset. Reproducing the issue: 1) Boot a VM with "-smp 2,maxcpus=3" or similar 2) device_add host-x86_64-cpu,id=vcpu,node-id=0,socket-id=0,core-id=2,thread-id=0 3) Wait a few seconds 4) device_del vcpu 5) Inside the VM run: # echo "t" >/proc/sysrq-trigger; dmesg | grep sched_clock_stable Observe the sched_clock_stable() value is 1. 6) Reboot the VM 7) Once the VM boots once again run inside it: # echo "t" >/proc/sysrq-trigger; dmesg | grep sched_clock_stable Observe the sched_clock_stable() value is now 0. Fixes: 5286c36622 ("target/i386: properly reset TSC on reset") Signed-off-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com> Link: https://lore.kernel.org/r/5a605a88e9a231386dc803c60f5fed9b48108139.1734014926.git.maciej.szmigiero@oracle.com Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>		2024-12-19 19:36:38 +01:00
..
kvm-accel-ops.c	cpu: move Qemu[Thread|Cond] setup into common code	2024-06-04 10:02:39 +02:00
kvm-all.c	target/i386: Reset TSCs of parked vCPUs too on VM reset	2024-12-19 19:36:38 +01:00
kvm-cpus.h	accel/kvm: Extract common KVM vCPU {creation,parking} code	2024-07-22 20:15:41 -04:00
meson.build	target/i386/kvm: Restrict SEV stubs to x86 architecture	2021-10-13 10:47:49 +02:00
trace-events	KVM: Dynamic sized kvm memslots array	2024-10-17 19:41:30 +02:00
trace.h	trace: switch position of headers to what Meson requires	2020-08-21 06:18:24 -04:00