mirror of
https://github.com/Motorhead1991/qemu.git
synced 2025-08-10 02:54:58 -06:00
e7bc0204e5
By changing the way the main QEMU event loop is invoked, I inadvertently
changed the BQL status of exit notifiers: some of them implicitly
assumed they would be called with the BQL held; the BQL is however
not held during the exit(status) call in qemu_default_main().
Instead of attempting to ensuring we always call exit() from the BQL -
including any transitive calls - this change adds a BQL lock guard to
qemu_run_exit_notifiers, ensuring the BQL will always be held in the
exit notifiers.
Additionally, the BQL promise is now documented at the
qemu_{add,remove}_exit_notifier() declarations.
Fixes: f5ab12caba ("ui & main loop: Redesign of system-specific main
thread event handling")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2771
Reported-by: David Woodhouse <dwmw@amazon.co.uk>
Signed-off-by: Phil Dennis-Jordan <phil@philjordan.eu>
Tested-by: David Woodhouse <dwmw@amazon.co.uk>
Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
115 lines
3.4 KiB
C
115 lines
3.4 KiB
C
#ifndef SYSTEM_H
|
|
#define SYSTEM_H
|
|
/* Misc. things related to the system emulator. */
|
|
|
|
#include "qemu/timer.h"
|
|
#include "qemu/notify.h"
|
|
#include "qemu/uuid.h"
|
|
|
|
/* vl.c */
|
|
|
|
extern int only_migratable;
|
|
extern const char *qemu_name;
|
|
extern QemuUUID qemu_uuid;
|
|
extern bool qemu_uuid_set;
|
|
|
|
const char *qemu_get_vm_name(void);
|
|
|
|
/* Exit notifiers will run with BQL held. */
|
|
void qemu_add_exit_notifier(Notifier *notify);
|
|
void qemu_remove_exit_notifier(Notifier *notify);
|
|
|
|
void qemu_add_machine_init_done_notifier(Notifier *notify);
|
|
void qemu_remove_machine_init_done_notifier(Notifier *notify);
|
|
|
|
void configure_rtc(QemuOpts *opts);
|
|
|
|
void qemu_init_subsystems(void);
|
|
|
|
extern int autostart;
|
|
|
|
typedef enum {
|
|
VGA_NONE, VGA_STD, VGA_CIRRUS, VGA_VMWARE, VGA_XENFB, VGA_QXL,
|
|
VGA_TCX, VGA_CG3, VGA_DEVICE, VGA_VIRTIO,
|
|
VGA_TYPE_MAX,
|
|
} VGAInterfaceType;
|
|
|
|
extern int vga_interface_type;
|
|
extern bool vga_interface_created;
|
|
|
|
extern int graphic_width;
|
|
extern int graphic_height;
|
|
extern int graphic_depth;
|
|
extern int display_opengl;
|
|
extern const char *keyboard_layout;
|
|
extern int old_param;
|
|
extern uint8_t *boot_splash_filedata;
|
|
extern bool enable_mlock;
|
|
extern bool enable_cpu_pm;
|
|
extern QEMUClockType rtc_clock;
|
|
|
|
#define MAX_OPTION_ROMS 16
|
|
typedef struct QEMUOptionRom {
|
|
const char *name;
|
|
int32_t bootindex;
|
|
} QEMUOptionRom;
|
|
extern QEMUOptionRom option_rom[MAX_OPTION_ROMS];
|
|
extern int nb_option_roms;
|
|
|
|
#define MAX_PROM_ENVS 128
|
|
extern const char *prom_envs[MAX_PROM_ENVS];
|
|
extern unsigned int nb_prom_envs;
|
|
|
|
/* serial ports */
|
|
|
|
/* Return the Chardev for serial port i, or NULL if none */
|
|
Chardev *serial_hd(int i);
|
|
|
|
/* parallel ports */
|
|
|
|
#define MAX_PARALLEL_PORTS 3
|
|
|
|
extern Chardev *parallel_hds[MAX_PARALLEL_PORTS];
|
|
|
|
void add_boot_device_path(int32_t bootindex, DeviceState *dev,
|
|
const char *suffix);
|
|
char *get_boot_devices_list(size_t *size);
|
|
|
|
DeviceState *get_boot_device(uint32_t position);
|
|
void check_boot_index(int32_t bootindex, Error **errp);
|
|
void del_boot_device_path(DeviceState *dev, const char *suffix);
|
|
void device_add_bootindex_property(Object *obj, int32_t *bootindex,
|
|
const char *name, const char *suffix,
|
|
DeviceState *dev);
|
|
void restore_boot_order(void *opaque);
|
|
void validate_bootdevices(const char *devices, Error **errp);
|
|
void add_boot_device_lchs(DeviceState *dev, const char *suffix,
|
|
uint32_t lcyls, uint32_t lheads, uint32_t lsecs);
|
|
void del_boot_device_lchs(DeviceState *dev, const char *suffix);
|
|
char *get_boot_devices_lchs_list(size_t *size);
|
|
|
|
/* handler to set the boot_device order for a specific type of MachineClass */
|
|
typedef void QEMUBootSetHandler(void *opaque, const char *boot_order,
|
|
Error **errp);
|
|
void qemu_register_boot_set(QEMUBootSetHandler *func, void *opaque);
|
|
void qemu_boot_set(const char *boot_order, Error **errp);
|
|
|
|
bool defaults_enabled(void);
|
|
|
|
void qemu_init(int argc, char **argv);
|
|
int qemu_main_loop(void);
|
|
void qemu_cleanup(int);
|
|
|
|
extern QemuOptsList qemu_legacy_drive_opts;
|
|
extern QemuOptsList qemu_common_drive_opts;
|
|
extern QemuOptsList qemu_drive_opts;
|
|
extern QemuOptsList bdrv_runtime_opts;
|
|
extern QemuOptsList qemu_chardev_opts;
|
|
extern QemuOptsList qemu_device_opts;
|
|
extern QemuOptsList qemu_netdev_opts;
|
|
extern QemuOptsList qemu_nic_opts;
|
|
extern QemuOptsList qemu_net_opts;
|
|
extern QemuOptsList qemu_global_opts;
|
|
extern QemuOptsList qemu_semihosting_config_opts;
|
|
|
|
#endif
|