Alberto Garcia 2f388b93a1 throttle: Check current timers before updating any_timer_armed[] ... Calling throttle_group_config() cancels all timers from a particular BlockDriverState, so any_timer_armed[] should be updated accordingly. However, with the current code it may happen that a timer is armed in a different BlockDriverState from the same group, so any_timer_armed[] would be set to false in a situation where there is still a timer armed. The consequence is that we might end up with two timers armed. This should not have any noticeable impact however, since all accesses to the ThrottleGroup are protected by a lock, and the situation would become normal again shortly thereafter as soon as all timers have been fired. The correct way to solve this is to check that we're actually cancelling a timer before updating any_timer_armed[]. Signed-off-by: Alberto Garcia <berto@igalia.com> Message-id: 1434382875-3998-1-git-send-email-berto@igalia.com Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>		2015-06-23 15:06:16 +01:00
..
accounting.c	block: add accounting for merged requests	2015-02-06 17:24:21 +01:00
archipelago.c	block: remove superfluous '\n' around error_report/error_setg	2015-03-10 08:15:33 +03:00
backup.c	Include qapi/qmp/qerror.h exactly where needed	2015-06-22 18:20:41 +02:00
blkdebug.c	block: Move flag inheritance to bdrv_open_inherit()	2015-06-12 17:04:59 +02:00
blkverify.c	block: Move flag inheritance to bdrv_open_inherit()	2015-06-12 17:04:59 +02:00
block-backend.c	block-backend: Expose bdrv_write_zeroes()	2015-04-28 15:36:08 +02:00
bochs.c	block: Use g_new() & friends to avoid multiplying sizes	2014-08-20 11:51:28 +02:00
cloop.c	cloop: Handle failure for potentially large allocations	2014-08-15 15:07:15 +02:00
commit.c	Include qapi/qmp/qerror.h exactly where needed	2015-06-22 18:20:41 +02:00
curl.c	qerror: Move #include out of qerror.h	2015-06-22 18:20:40 +02:00
dmg.c	qerror: Move #include out of qerror.h	2015-06-22 18:20:40 +02:00
gluster.c	block: don't convert file size to sector size	2014-09-12 15:43:06 +02:00
io.c	block: Let bdrv_drain_all() to call aio_poll() for each AioContext	2015-06-23 15:06:16 +01:00
iscsi.c	qerror: Move #include out of qerror.h	2015-06-22 18:20:40 +02:00
linux-aio.c	linux-aio: simplify removal of completed iocbs from the list	2014-12-12 16:57:55 +00:00
Makefile.objs	throttle: Add throttle group infrastructure	2015-06-12 14:00:00 +01:00
mirror.c	Include qapi/qmp/qerror.h exactly where needed	2015-06-22 18:20:41 +02:00
nbd-client.c	nbd: Set block size to BDRV_SECTOR_SIZE	2015-03-18 12:07:01 +01:00
nbd-client.h	nbd: Set block size to BDRV_SECTOR_SIZE	2015-03-18 12:07:01 +01:00
nbd.c	nbd: Fix nbd_establish_connection()'s return value	2015-03-18 12:05:38 +01:00
nfs.c	block/nfs: Add create_opts	2014-12-10 10:31:19 +01:00
null.c	block/null: Support reopen	2015-04-28 15:36:09 +02:00
parallels.c	block/parallels: improve image writing performance further	2015-05-22 09:37:32 +01:00
qapi.c	qerror: Finally unused, clean up	2015-06-22 18:20:40 +02:00
qcow.c	Include qapi/qmp/qerror.h exactly where needed	2015-06-22 18:20:41 +02:00
qcow2-cache.c	qcow2: style fixes in qcow2-cache.c	2015-05-22 17:08:01 +02:00
qcow2-cluster.c	qcow2/qcow: protect against uninitialized encryption key	2015-05-22 17:08:01 +02:00
qcow2-refcount.c	qcow2: make qcow2_cache_put() a void function	2015-05-22 17:08:01 +02:00
qcow2-snapshot.c	qerror: Move #include out of qerror.h	2015-06-22 18:20:40 +02:00
qcow2.c	qerror: Clean up QERR_ macros to expand into a single string	2015-06-22 18:20:40 +02:00
qcow2.h	qcow2: Add DEFAULT_L2_CACHE_CLUSTERS	2015-06-12 15:54:01 +02:00
qed-check.c	block: Use g_new() & friends to avoid multiplying sizes	2014-08-20 11:51:28 +02:00
qed-cluster.c	Use glib memory allocation and free functions	2011-08-20 23:01:08 -05:00
qed-gencb.c	block: Rename BlockDriverCompletionFunc to BlockCompletionFunc	2014-10-20 13:41:27 +02:00
qed-l2-cache.c	qed: do not evict in-use L2 table cache entries	2012-03-12 15:14:06 +01:00
qed-table.c	block: Rename BlockDriverCompletionFunc to BlockCompletionFunc	2014-10-20 13:41:27 +02:00
qed.c	qerror: Clean up QERR_ macros to expand into a single string	2015-06-22 18:20:40 +02:00
qed.h	qed: Really remove unused field QEDAIOCB.finished	2015-02-06 17:24:21 +01:00
quorum.c	Include qapi/qmp/qerror.h exactly where needed	2015-06-22 18:20:41 +02:00
raw-aio.h	linux-aio: drop return code from laio_io_unplug and ioq_submit	2014-12-12 16:57:55 +00:00
raw-posix.c	qerror: Move #include out of qerror.h	2015-06-22 18:20:40 +02:00
raw-win32.c	qerror: Move #include out of qerror.h	2015-06-22 18:20:40 +02:00
raw_bsd.c	block: Add driver methods to probe blocksizes and geometry	2015-03-10 14:02:22 +01:00
rbd.c	Convert (ffs(val) - 1) to ctz32(val)	2015-04-28 15:36:08 +02:00
sheepdog.c	sheepdog: fix resource leak with sd_snapshot_create	2015-05-08 14:11:10 +03:00
snapshot.c	Include qapi/qmp/qerror.h exactly where needed	2015-06-22 18:20:41 +02:00
ssh.c	qerror: Move #include out of qerror.h	2015-06-22 18:20:40 +02:00
stream.c	Include qapi/qmp/qerror.h exactly where needed	2015-06-22 18:20:41 +02:00
throttle-groups.c	throttle: Check current timers before updating any_timer_armed[]	2015-06-23 15:06:16 +01:00
vdi.c	block: use bdrv_get_device_or_node_name() in error messages	2015-04-28 15:36:09 +02:00
vhdx-endian.c	block: VHDX endian fixes	2014-08-15 15:07:14 +02:00
vhdx-log.c	qerror: Move #include out of qerror.h	2015-06-22 18:20:40 +02:00
vhdx.c	block: use bdrv_get_device_or_node_name() in error messages	2015-04-28 15:36:09 +02:00
vhdx.h	block: vhdx - update PAYLOAD_BLOCK_UNMAPPED value to match 1.00 spec	2014-12-12 15:42:22 +00:00
vmdk.c	Include qapi/qmp/qerror.h exactly where needed	2015-06-22 18:20:41 +02:00
vpc.c	block: use bdrv_get_device_or_node_name() in error messages	2015-04-28 15:36:09 +02:00
vvfat.c	qerror: Move #include out of qerror.h	2015-06-22 18:20:40 +02:00
win32-aio.c	block: Rename BlockDriverCompletionFunc to BlockCompletionFunc	2014-10-20 13:41:27 +02:00
write-threshold.c	block: Fix block-set-write-threshold not to use funky error class	2015-03-16 17:07:25 +01:00