mirror of
https://github.com/Motorhead1991/qemu.git
synced 2025-08-01 14:53:54 -06:00
2e3b166c41
It is confusing having many different pieces of code enabling and disabling commands, and it is not clear that they all have the same semantics, especially wrt prioritization of the block/allow lists. The code attempted to prevent the user from setting both the block and allow lists concurrently, however, the logic was flawed as it checked settings in the configuration file separately from the command line arguments. Thus it was possible to set a block list in the config file and an allow list via a command line argument. The --dump-conf option also creates a configuration file with both keys present, even if unset, which means it is creating a config that cannot actually be loaded again. Centralizing the code in a single method "ga_apply_command_filters" will provide a strong guarantee of consistency and clarify the intended behaviour. With this there is no compelling technical reason to prevent concurrent setting of both the allow and block lists, so this flawed restriction is removed. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com> Message-ID: <20240712132459.3974109-23-berrange@redhat.com> Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com> |
||
|---|---|---|
| .. | ||
| barrier.rst | ||
| bitmaps.rst | ||
| dbus-display.rst | ||
| dbus-vmstate.rst | ||
| dbus.rst | ||
| firmware.json | ||
| index.rst | ||
| live-block-operations.rst | ||
| nbd.txt | ||
| parallels.txt | ||
| pr-helper.rst | ||
| prl-xml.txt | ||
| qcow2.txt | ||
| qed_spec.txt | ||
| qemu-ga-ref.rst | ||
| qemu-ga.rst | ||
| qemu-qmp-ref.rst | ||
| qemu-storage-daemon-qmp-ref.rst | ||
| qmp-spec.rst | ||
| vhost-user-gpu.rst | ||
| vhost-user.json | ||
| vhost-user.rst | ||
| vhost-vdpa.rst | ||
| virtio-balloon-stats.rst | ||
| vnc-ledstate-pseudo-encoding.rst | ||