motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2026-02-21 03:42:18 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions
qemu/util
History
Markus Armbruster 37f32349ea QemuOpts: Fix qemu_opts_foreach() dangling location regression 
qemu_opts_foreach() pushes and pops a Location with automatic storage
duration.  Except it fails to pop when @func() returns non-zero.
cur_loc then points to unused stack space, and will most likely get
clobbered in short order.

Clobbered cur_loc can make loc_pop() and error_print_loc() crash or
report bogus locations.

Affects several qemu command line options as well as qemu-img,
qemu-io, qemu-nbd -object, and blkdebug's configuration file.

Broken in commit a4c7367, v2.4.0.

Reproducer:
    $ qemu-system-x86_64 -nodefaults -display none -object secret,id=foo,foo=bar

main() reports "Property '.foo' not found" like this:

    if (qemu_opts_foreach(qemu_find_opts("object"),
                          user_creatable_add_opts_foreach,
                          object_create_delayed, &err)) {
        error_report_err(err);
        exit(1);
    }

cur_loc then points to where qemu_opts_foreach()'s Location used to
be, i.e. unused stack space.  With optimization, this Location doesn't
get clobbered for me, and also happens to be the correct location.
Without optimization, it does get clobbered in a way that makes
error_report_err() report no location.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <1461767349-15329-2-git-send-email-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
2016-04-28 08:18:56 +02:00
..
acl.c
base64.c include/qemu/osdep.h: Don't include qapi/error.h 2016-03-22 22:20:15 +01:00
bitmap.c
bitops.c
buffer.c
compatfd.c
coroutine-gthread.c
coroutine-sigaltstack.c
coroutine-ucontext.c
coroutine-win32.c
crc32c.c
cutils.c util: move declarations out of qemu-common.h 2016-03-22 22:20:17 +01:00
envlist.c
error.c include/qemu/osdep.h: Don't include qapi/error.h 2016-03-22 22:20:15 +01:00
event_notifier-posix.c event-notifier: Add "is_external" parameter 2016-04-22 16:43:56 +02:00
event_notifier-win32.c event-notifier: Add "is_external" parameter 2016-04-22 16:43:56 +02:00
fifo8.c
getauxval.c
hbitmap.c
hexdump.c util: Improved qemu_hexmap() to include an ascii dump of the buffer 2016-04-06 09:52:07 +08:00
host-utils.c
id.c util: move declarations out of qemu-common.h 2016-03-22 22:20:17 +01:00
iov.c util: move declarations out of qemu-common.h 2016-03-22 22:20:17 +01:00
log.c log: move qemu_log_close/qemu_log_flush from header to log.c 2016-03-31 09:58:32 +01:00
Makefile.objs
memfd.c
mmap-alloc.c
module.c
notify.c
osdep.c util: move declarations out of qemu-common.h 2016-03-22 22:20:17 +01:00
oslib-posix.c util: align memory allocations to 2M on AArch64 2016-04-22 12:26:01 +01:00
oslib-win32.c util: move declarations out of qemu-common.h 2016-03-22 22:20:17 +01:00
path.c util: move declarations out of qemu-common.h 2016-03-22 22:20:17 +01:00
qemu-config.c
qemu-coroutine-io.c
qemu-coroutine-lock.c
qemu-coroutine-sleep.c
qemu-coroutine.c
qemu-error.c
qemu-openpty.c
qemu-option.c QemuOpts: Fix qemu_opts_foreach() dangling location regression 2016-04-28 08:18:56 +02:00
qemu-progress.c
qemu-sockets.c util: retry getaddrinfo if getting EAI_BADFLAGS with AI_V4MAPPED 2016-04-05 11:46:52 +02:00
qemu-thread-posix.c
qemu-thread-win32.c
qemu-timer-common.c
rcu.c
readline.c util: move declarations out of qemu-common.h 2016-03-22 22:20:17 +01:00
rfifolock.c
throttle.c include/qemu/osdep.h: Don't include qapi/error.h 2016-03-22 22:20:15 +01:00
timed-average.c
unicode.c util: move declarations out of qemu-common.h 2016-03-22 22:20:17 +01:00
uri.c