Fabiano Rosas 4a228bcc99 migration: Don't set FAILED state when cancelling ... The expected outcome from qmp_migrate_cancel() is that the source migration goes to the terminal state MIGRATION_STATUS_CANCELLED. Anything different from this is a bug when cancelling. Make sure there is never a state transition from an unspecified state into FAILED. Code that sets FAILED, should always either make sure that the old state is not CANCELLING or specify the old state. Note that the destination is allowed to go into FAILED, so there's no issue there. (I don't think this is relevant as a backport because cancelling does work, it just doesn't show the right state at the end) Fixes: 3dde8fdbad ("migration: Merge precopy/postcopy on switchover start") Fixes: d0edb8a173 ("migration: Create the postcopy preempt channel asynchronously") Fixes: 8518278a6a ("migration: implementation of background snapshot thread") Fixes: bf78a046b9 ("migration: refactor migrate_fd_connect failures") Reviewed-by: Peter Xu <peterx@redhat.com> Message-ID: <20250213175927.19642-7-farosas@suse.de> Signed-off-by: Fabiano Rosas <farosas@suse.de>		2025-02-14 15:19:06 -03:00
..
block-active.c	migration/block-active: Remove global active flag	2025-02-06 14:26:51 +01:00
block-dirty-bitmap.c	include: Rename sysemu/ -> system/	2024-12-20 17:44:56 +01:00
channel-block.c	io: follow coroutine AioContext in qio_channel_yield()	2023-09-07 20:32:11 -05:00
channel-block.h	migration: introduce a QIOChannel impl for BlockDriverState VMState	2022-06-22 19:33:43 +01:00
channel.c	migration: Fix hang after error in destination setup phase	2025-02-14 15:19:05 -03:00
channel.h	migration: check magic value for deciding the mapping of channels	2023-02-06 19:22:57 +01:00
colo-failover.c	migration/colo: Improve an x-colo-lost-heartbeat error message	2023-02-23 14:10:17 +01:00
colo-stubs.c	migration/colo: make colo_incoming_co() return void	2024-05-22 17:34:31 -03:00
colo.c	migration/block: Rewrite disk activation	2025-01-09 17:38:57 -03:00
cpr-transfer.c	migration: cpr-transfer save and load	2025-01-29 11:43:05 -03:00
cpr.c	migration: cpr-transfer mode	2025-01-29 11:56:24 -03:00
cpu-throttle.c	include: Rename sysemu/ -> system/	2024-12-20 17:44:56 +01:00
dirtyrate.c	qapi: Move include/qapi/qmp/ to include/qobject/	2025-02-10 15:33:16 +01:00
dirtyrate.h	include: Rename sysemu/ -> system/	2024-12-20 17:44:56 +01:00
exec.c	migration: simplify exec migration functions	2024-03-04 07:12:40 +01:00
exec.h	migration: convert exec backend to accept MigrateAddress.	2023-11-02 11:35:04 +01:00
fd.c	migration: Allow pipes to keep working for fd migrations	2024-11-25 16:21:55 -05:00
fd.h	migration: Revert mapped-ram multifd support to fd: URI	2024-03-22 12:12:08 -04:00
file.c	migration/multifd: Pass in MultiFDPages_t to file_write_ramblock_iov	2024-09-03 16:24:35 -03:00
file.h	migration/multifd: Pass in MultiFDPages_t to file_write_ramblock_iov	2024-09-03 16:24:35 -03:00
global_state.c	include: Rename sysemu/ -> system/	2024-12-20 17:44:56 +01:00
meson.build	migration: cpr-transfer save and load	2025-01-29 11:43:05 -03:00
migration-hmp-cmds.c	qapi: Move include/qapi/qmp/ to include/qobject/	2025-02-10 15:33:16 +01:00
migration-stats.c	migration: migration_rate_limit_reset() don't need the QEMUFile	2023-10-31 08:44:33 +01:00
migration-stats.h	migration: Remove transferred atomic counter	2023-10-31 08:44:33 +01:00
migration.c	migration: Don't set FAILED state when cancelling	2025-02-14 15:19:06 -03:00
migration.h	migration: Change migrate_fd_ to migration_	2025-02-14 15:19:05 -03:00
multifd-nocomp.c	multifd: bugfix for migration using compression methods	2025-01-09 17:40:15 -03:00
multifd-qatzip.c	multifd: bugfix for incorrect migration data with qatzip compression	2025-01-09 17:40:27 -03:00
multifd-qpl.c	multifd: bugfix for incorrect migration data with QPL compression	2025-01-09 17:40:21 -03:00
multifd-uadk.c	migration/multifd: Fix compile error caused by page_size usage	2025-01-09 17:37:50 -03:00
multifd-zero-page.c	migration/multifd: Move pages accounting into multifd_send_zero_page_detect()	2024-09-03 16:24:35 -03:00
multifd-zlib.c	migration/multifd: Make MultiFDMethods const	2024-09-03 16:24:36 -03:00
multifd-zstd.c	migration/multifd: Fix loop conditions in multifd_zstd_send_prepare and multifd_zstd_recv	2024-09-18 14:27:24 -04:00
multifd.c	migration: Change migrate_fd_ to migration_	2025-02-14 15:19:05 -03:00
multifd.h	migration/multifd: Add a compat property for TLS termination	2025-02-14 15:19:04 -03:00
options.c	migration/multifd: Add a compat property for TLS termination	2025-02-14 15:19:04 -03:00
options.h	migration: Use device_class_set_props_n	2024-12-19 19:33:37 +01:00
page_cache.c	migration: Fix cache_init()'s "Failed to allocate" error messages	2021-02-08 11:19:51 +00:00
page_cache.h	migration: Clean up signed vs. unsigned XBZRLE cache-size	2021-02-08 11:19:51 +00:00
postcopy-ram.c	include: Rename sysemu/ -> system/	2024-12-20 17:44:56 +01:00
postcopy-ram.h	migration/postcopy: Add postcopy-recover-setup phase	2024-06-21 09:47:59 -03:00
qemu-file.c	migration: SCM_RIGHTS for QEMUFile	2025-01-29 11:43:05 -03:00
qemu-file.h	migration: SCM_RIGHTS for QEMUFile	2025-01-29 11:43:05 -03:00
ram.c	migration: Set migration error outside of migrate_cancel	2025-02-14 15:19:05 -03:00
ram.h	migration/ram: Move RAM_SAVE_FLAG* into ram.h	2025-01-09 17:38:15 -03:00
rdma.c	migration: Change migrate_fd_ to migration_	2025-02-14 15:19:05 -03:00
rdma.h	migration/ram: Move RAM_SAVE_FLAG* into ram.h	2025-01-09 17:38:15 -03:00
savevm.c	migration: Check migration error after loadvm	2025-02-14 15:19:04 -03:00
savevm.h	migration: Unwrap qemu_savevm_state_complete_precopy() in postcopy	2025-01-29 11:56:41 -03:00
socket.c	migration: Remove unused socket_send_channel_create_sync	2024-10-08 15:28:55 -04:00
socket.h	migration: Remove unused socket_send_channel_create_sync	2024-10-08 15:28:55 -04:00
target.c	migration: Add migration prefix to functions in target.c	2023-09-11 08:34:06 +02:00
threadinfo.c	migration/multifd: Protect accesses to migration_threads	2023-07-26 10:55:56 +02:00
threadinfo.h	migration/multifd: Protect accesses to migration_threads	2023-07-26 10:55:56 +02:00
tls.c	migration/multifd: Terminate the TLS connection	2025-02-14 15:19:04 -03:00
tls.h	migration/multifd: Terminate the TLS connection	2025-02-14 15:19:04 -03:00
trace-events	migration: Change migrate_fd_ to migration_	2025-02-14 15:19:05 -03:00
trace.h	trace: switch position of headers to what Meson requires	2020-08-21 06:18:24 -04:00
vmstate-types.c	migration: cpr-transfer mode	2025-01-29 11:56:24 -03:00
vmstate.c	qapi: Move include/qapi/qmp/ to include/qobject/	2025-02-10 15:33:16 +01:00
xbzrle.c	migration/xbzrle: Use i386 host/cpuinfo.h	2023-05-23 16:51:18 -07:00
xbzrle.h	migration/xbzrle: Use i386 host/cpuinfo.h	2023-05-23 16:51:18 -07:00
yank_functions.c	migration/yank: Use channel features	2024-01-29 11:02:12 +08:00
yank_functions.h	migration: Move the yank unregister of channel_close out	2021-07-26 12:45:03 +01:00