mirror of
https://github.com/Motorhead1991/qemu.git
synced 2025-08-02 23:33:54 -06:00
19f7034773
The address_space_rw() function allows either reads or writes depending on the is_write argument passed to it; this is useful when the direction of the access is determined programmatically (as for instance when handling the KVM_EXIT_MMIO exit reason). Under the hood it just calls either address_space_write() or address_space_read_full(). We also use it a lot with a constant is_write argument, though, which has two issues: * when reading "address_space_rw(..., 1)" this is less immediately clear to the reader as being a write than "address_space_write(...)" * calling address_space_rw() bypasses the optimization in address_space_read() that fast-paths reads of a fixed length This commit was produced with the included Coccinelle script scripts/coccinelle/exec_rw_const.cocci. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> Reviewed-by: Laurent Vivier <lvivier@redhat.com> Reviewed-by: Cédric Le Goater <clg@kaod.org> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com> Reviewed-by: Cornelia Huck <cohuck@redhat.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Acked-by: David Gibson <david@gibson.dropbear.id.au> Message-Id: <20200218112457.22712-1-peter.maydell@linaro.org> [PMD: Update macvm_set_cr0() reported by Laurent Vivier] Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
85 lines
1.9 KiB
Text
85 lines
1.9 KiB
Text
/*
|
|
Usage:
|
|
|
|
spatch \
|
|
--macro-file scripts/cocci-macro-file.h \
|
|
--sp-file scripts/coccinelle/exec_rw_const.cocci \
|
|
--keep-comments \
|
|
--in-place \
|
|
--dir .
|
|
*/
|
|
|
|
// Convert to boolean
|
|
@@
|
|
expression E1, E2, E3, E4, E5;
|
|
@@
|
|
(
|
|
- address_space_rw(E1, E2, E3, E4, E5, 0)
|
|
+ address_space_rw(E1, E2, E3, E4, E5, false)
|
|
|
|
|
- address_space_rw(E1, E2, E3, E4, E5, 1)
|
|
+ address_space_rw(E1, E2, E3, E4, E5, true)
|
|
)
|
|
|
|
// Use address_space_write instead of casting to non-const
|
|
@@
|
|
type T;
|
|
const T *V;
|
|
expression E1, E2, E3, E4;
|
|
@@
|
|
(
|
|
- address_space_rw(E1, E2, E3, (T *)V, E4, 1)
|
|
+ address_space_write(E1, E2, E3, V, E4)
|
|
|
|
|
- address_space_rw(E1, E2, E3, (void *)V, E4, 1)
|
|
+ address_space_write(E1, E2, E3, V, E4)
|
|
)
|
|
|
|
// Avoid uses of address_space_rw() with a constant is_write argument.
|
|
@@
|
|
expression E1, E2, E3, E4, E5;
|
|
symbol true, false;
|
|
@@
|
|
(
|
|
- address_space_rw(E1, E2, E3, E4, E5, false)
|
|
+ address_space_read(E1, E2, E3, E4, E5)
|
|
|
|
|
- address_space_rw(E1, E2, E3, E4, E5, true)
|
|
+ address_space_write(E1, E2, E3, E4, E5)
|
|
)
|
|
|
|
// Remove useless cast
|
|
@@
|
|
expression E1, E2, E3, E4, E5, E6;
|
|
type T;
|
|
@@
|
|
(
|
|
- address_space_rw(E1, E2, E3, (T *)(E4), E5, E6)
|
|
+ address_space_rw(E1, E2, E3, E4, E5, E6)
|
|
|
|
|
- address_space_read(E1, E2, E3, (T *)(E4), E5)
|
|
+ address_space_read(E1, E2, E3, E4, E5)
|
|
|
|
|
- address_space_write(E1, E2, E3, (T *)(E4), E5)
|
|
+ address_space_write(E1, E2, E3, E4, E5)
|
|
|
|
|
- address_space_write_rom(E1, E2, E3, (T *)(E4), E5)
|
|
+ address_space_write_rom(E1, E2, E3, E4, E5)
|
|
|
|
|
|
|
- cpu_physical_memory_rw(E1, (T *)(E2), E3, E4)
|
|
+ cpu_physical_memory_rw(E1, E2, E3, E4)
|
|
|
|
|
- cpu_physical_memory_read(E1, (T *)(E2), E3)
|
|
+ cpu_physical_memory_read(E1, E2, E3)
|
|
|
|
|
- cpu_physical_memory_write(E1, (T *)(E2), E3)
|
|
+ cpu_physical_memory_write(E1, E2, E3)
|
|
|
|
|
|
|
- dma_memory_read(E1, E2, (T *)(E3), E4)
|
|
+ dma_memory_read(E1, E2, E3, E4)
|
|
|
|
|
- dma_memory_write(E1, E2, (T *)(E3), E4)
|
|
+ dma_memory_write(E1, E2, E3, E4)
|
|
)
|