mirror of
https://github.com/Motorhead1991/qemu.git
synced 2025-08-02 07:13:54 -06:00
0f799b83bd
Block sizes need to be a power of two between 512 and an arbitrary
limit, currently 2MiB.
Commit 5937835ac4 factored block size checking out of set_blocksize()
into new check_block_size(), for reuse in block/export/.
Its two error messages are okay for the original purpose:
$ qemu-system-x86_64 -device ide-hd,physical_block_size=1
qemu-system-x86_64: -device ide-hd,physical_block_size=1: Property .physical_block_size doesn't take value 1 (minimum: 512, maximum: 2097152)
$ qemu-system-x86_64 -device ide-hd,physical_block_size=513
qemu-system-x86_64: -device ide-hd,physical_block_size=513: Property .physical_block_size doesn't take value '513', it's not a power of 2
They're mildly off for block exports:
$ qemu-storage-daemon --blockdev node-name=nod0,driver=file,filename=foo.img --export type=vduse-blk,id=exp0,node-name=nod0,name=foo,logical-block-size=1
qemu-storage-daemon: --export type=vduse-blk,id=exp0,node-name=nod0,name=foo,logical-block-size=1: Property exp0.logical-block-size doesn't take value 1 (minimum: 512, maximum: 2097152)
The error message talks about a property. CLI options like --export
don't have properties, they have parameters.
Replace the two error messages by a single one that's okay for both
purposes. Looks like this:
qemu-storage-daemon: --export type=vduse-blk,id=exp0,node-name=nod0,name=foo,logical-block-size=1: parameter logical-block-size must be a power of 2 between 512 and 2097152
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20241010150144.986655-3-armbru@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
42 lines
1.1 KiB
C
42 lines
1.1 KiB
C
/*
|
|
* Block utility functions
|
|
*
|
|
* Copyright IBM, Corp. 2011
|
|
* Copyright (c) 2020 Coiby Xu <coiby.xu@gmail.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "qapi/error.h"
|
|
#include "block-helpers.h"
|
|
|
|
/**
|
|
* check_block_size:
|
|
* @id: The unique ID of the object
|
|
* @name: The name of the property being validated
|
|
* @value: The block size in bytes
|
|
* @errp: A pointer to an area to store an error
|
|
*
|
|
* This function checks that the block size meets the following conditions:
|
|
* 1. At least MIN_BLOCK_SIZE
|
|
* 2. No larger than MAX_BLOCK_SIZE
|
|
* 3. A power of 2
|
|
*/
|
|
void check_block_size(const char *id, const char *name, int64_t value,
|
|
Error **errp)
|
|
{
|
|
if (!value) {
|
|
/* unset */
|
|
return;
|
|
}
|
|
|
|
if (value < MIN_BLOCK_SIZE || value > MAX_BLOCK_SIZE
|
|
|| (value & (value - 1))) {
|
|
error_setg(errp,
|
|
"parameter %s must be a power of 2 between %" PRId64
|
|
" and %" PRId64,
|
|
name, MIN_BLOCK_SIZE, MAX_BLOCK_SIZE);
|
|
}
|
|
}
|