mirror of
https://github.com/Motorhead1991/qemu.git
synced 2025-12-19 05:58:35 -07:00
6a67577d80
romsize is an uint32_t variable. Specifying -1 as an uint32_t value is
obscure way to denote UINT32_MAX.
Worse, if int is wider than 32-bit, it will change the behavior of a
construct like the following:
romsize = -1;
if (romsize != -1) {
...
}
When -1 is assigned to romsize, -1 will be implicitly casted into
uint32_t, resulting in UINT32_MAX. On contrary, when evaluating
romsize != -1, romsize will be casted into int, and it will be a
comparison of UINT32_MAX and -1, and result in false.
Replace -1 with UINT32_MAX for statements involving the variable to
clarify the intent and prevent potential breakage.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20240627-reuse-v10-10-7ca0b8ed3d9f@daynix.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
|
||
|---|---|---|
| .. | ||
| Kconfig | ||
| meson.build | ||
| trace-events | ||
| trace.h | ||
| xen-backend.c | ||
| xen-bus-helper.c | ||
| xen-bus.c | ||
| xen-host-pci-device.c | ||
| xen-host-pci-device.h | ||
| xen-hvm-common.c | ||
| xen-legacy-backend.c | ||
| xen-mapcache.c | ||
| xen-operations.c | ||
| xen_devconfig.c | ||
| xen_pt.c | ||
| xen_pt.h | ||
| xen_pt_config_init.c | ||
| xen_pt_graphics.c | ||
| xen_pt_load_rom.c | ||
| xen_pt_msi.c | ||
| xen_pt_stub.c | ||
| xen_pvdev.c | ||