mirror of
https://github.com/Motorhead1991/qemu.git
synced 2025-12-11 16:00:50 -07:00
ae909496e9
QEMU currently crashes when you try to hot-plug an "nvdimm" device
on older machine types:
$ qemu-system-x86_64 -monitor stdio -M pc-1.1
QEMU 3.1.92 monitor - type 'help' for more information
(qemu) device_add nvdimm,id=nvdimmn1
qemu-system-x86_64: /home/thuth/devel/qemu/util/error.c:57: error_setv:
Assertion `*errp == ((void *)0)' failed.
Aborted (core dumped)
The call to hotplug_handler_pre_plug() in pc_memory_pre_plug() has been
added recently before the check whether nvdimm is enabled. It should
be done after the check. And while we're at it, also check the errp
after the hotplug_handler_pre_plug(), otherwise errors are silently
ignored here.
Fixes:
|
||
|---|---|---|
| .. | ||
| kvm | ||
| xen | ||
| acpi-build.c | ||
| acpi-build.h | ||
| amd_iommu.c | ||
| amd_iommu.h | ||
| intel_iommu.c | ||
| intel_iommu_internal.h | ||
| Kconfig | ||
| kvmvapic.c | ||
| Makefile.objs | ||
| multiboot.c | ||
| multiboot.h | ||
| pc.c | ||
| pc_piix.c | ||
| pc_q35.c | ||
| pc_sysfw.c | ||
| trace-events | ||
| vmmouse.c | ||
| vmport.c | ||
| x86-iommu.c | ||