mirror of
https://github.com/Motorhead1991/qemu.git
synced 2026-02-02 06:10:39 -07:00
430671f526
When the source VM attempts to connect to the destination VM's Unix domain socket (cpr.sock) during a cpr-transfer test, race conditions can occur if the socket file isn't ready. This can lead to connection failures when running tests. This patch creates and listens on the socket in advance, and passes the pre-listened FD directly. This avoids timing issues and improves the reliability of CPR tests. Reviewed-by: Jason J. Herne <jjherne@linux.ibm.com> Signed-off-by: Jaehoon Kim <jhkim@linux.ibm.com> Reviewed-by: Steve Sistare <steven.sistare@oracle.com> Link: https://lore.kernel.org/r/20250611205610.147008-2-jhkim@linux.ibm.com [peterx: null-initialize opts_target, per Steve] Signed-off-by: Peter Xu <peterx@redhat.com>
136 lines
4 KiB
C
136 lines
4 KiB
C
/*
|
|
* QTest testcases for CPR
|
|
*
|
|
* Copyright (c) 2016-2018 Red Hat, Inc. and/or its affiliates
|
|
* based on the vhost-user-test.c that is:
|
|
* Copyright (c) 2014 Virtual Open Systems Sarl.
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "libqtest.h"
|
|
#include "migration/framework.h"
|
|
#include "migration/migration-qmp.h"
|
|
#include "migration/migration-util.h"
|
|
|
|
|
|
static char *tmpfs;
|
|
|
|
static void *migrate_hook_start_mode_reboot(QTestState *from, QTestState *to)
|
|
{
|
|
migrate_set_parameter_str(from, "mode", "cpr-reboot");
|
|
migrate_set_parameter_str(to, "mode", "cpr-reboot");
|
|
|
|
return NULL;
|
|
}
|
|
|
|
static void test_mode_reboot(void)
|
|
{
|
|
g_autofree char *uri = g_strdup_printf("file:%s/%s", tmpfs,
|
|
FILE_TEST_FILENAME);
|
|
MigrateCommon args = {
|
|
.start.use_shmem = true,
|
|
.connect_uri = uri,
|
|
.listen_uri = "defer",
|
|
.start_hook = migrate_hook_start_mode_reboot,
|
|
.start = {
|
|
.caps[MIGRATION_CAPABILITY_X_IGNORE_SHARED] = true,
|
|
},
|
|
};
|
|
|
|
test_file_common(&args, true);
|
|
}
|
|
|
|
static void *test_mode_transfer_start(QTestState *from, QTestState *to)
|
|
{
|
|
migrate_set_parameter_str(from, "mode", "cpr-transfer");
|
|
return NULL;
|
|
}
|
|
|
|
/*
|
|
* cpr-transfer mode cannot use the target monitor prior to starting the
|
|
* migration, and cannot connect synchronously to the monitor, so defer
|
|
* the target connection.
|
|
*/
|
|
static void test_mode_transfer_common(bool incoming_defer)
|
|
{
|
|
g_autofree char *cpr_path = g_strdup_printf("%s/cpr.sock", tmpfs);
|
|
g_autofree char *mig_path = g_strdup_printf("%s/migsocket", tmpfs);
|
|
g_autofree char *uri = g_strdup_printf("unix:%s", mig_path);
|
|
g_autofree char *opts_target = NULL;
|
|
|
|
const char *opts = "-machine aux-ram-share=on -nodefaults";
|
|
g_autofree const char *cpr_channel = g_strdup_printf(
|
|
"cpr,addr.transport=socket,addr.type=unix,addr.path=%s",
|
|
cpr_path);
|
|
|
|
g_autofree char *connect_channels = g_strdup_printf(
|
|
"[ { 'channel-type': 'main',"
|
|
" 'addr': { 'transport': 'socket',"
|
|
" 'type': 'unix',"
|
|
" 'path': '%s' } } ]",
|
|
mig_path);
|
|
|
|
/*
|
|
* Set up a UNIX domain socket for the CPR channel before
|
|
* launching the destination VM, to avoid timing issues
|
|
* during connection setup.
|
|
*/
|
|
int cpr_sockfd = qtest_socket_server(cpr_path);
|
|
g_assert(cpr_sockfd >= 0);
|
|
|
|
opts_target = g_strdup_printf("-incoming cpr,addr.transport=socket,"
|
|
"addr.type=fd,addr.str=%d %s",
|
|
cpr_sockfd, opts);
|
|
MigrateCommon args = {
|
|
.start.opts_source = opts,
|
|
.start.opts_target = opts_target,
|
|
.start.defer_target_connect = true,
|
|
.start.memory_backend = "-object memory-backend-memfd,id=pc.ram,size=%s"
|
|
" -machine memory-backend=pc.ram",
|
|
.listen_uri = incoming_defer ? "defer" : uri,
|
|
.connect_channels = connect_channels,
|
|
.cpr_channel = cpr_channel,
|
|
.start_hook = test_mode_transfer_start,
|
|
};
|
|
|
|
test_precopy_common(&args);
|
|
}
|
|
|
|
static void test_mode_transfer(void)
|
|
{
|
|
test_mode_transfer_common(NULL);
|
|
}
|
|
|
|
static void test_mode_transfer_defer(void)
|
|
{
|
|
test_mode_transfer_common(true);
|
|
}
|
|
|
|
void migration_test_add_cpr(MigrationTestEnv *env)
|
|
{
|
|
tmpfs = env->tmpfs;
|
|
|
|
/* no tests in the smoke set for now */
|
|
|
|
if (!env->full_set) {
|
|
return;
|
|
}
|
|
|
|
/*
|
|
* Our CI system has problems with shared memory.
|
|
* Don't run this test until we find a workaround.
|
|
*/
|
|
if (getenv("QEMU_TEST_FLAKY_TESTS")) {
|
|
migration_test_add("/migration/mode/reboot", test_mode_reboot);
|
|
}
|
|
|
|
if (env->has_kvm) {
|
|
migration_test_add("/migration/mode/transfer", test_mode_transfer);
|
|
migration_test_add("/migration/mode/transfer/defer",
|
|
test_mode_transfer_defer);
|
|
}
|
|
}
|