mirror of
https://github.com/Motorhead1991/qemu.git
synced 2025-07-26 11:53:53 -06:00

Peter Krempa and Kevin Wolf observed that iothread-vq-mapping is confusing to use because the control and event virtqueues have a fixed location before the command virtqueues but need to be treated differently. Only expose the command virtqueues via iothread-vq-mapping so that the command-line parameter is intuitive: it controls where SCSI requests are processed. The control virtqueue needs to be hardcoded to the main loop thread for technical reasons anyway. Kevin also pointed out that it's better to place the event virtqueue in the main loop thread since its no poll behavior would prevent polling if assigned to an IOThread. This change is its own commit to avoid squashing the previous commit. Suggested-by: Kevin Wolf <kwolf@redhat.com> Suggested-by: Peter Krempa <pkrempa@redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Message-ID: <20250311132616.1049687-14-stefanha@redhat.com> Tested-by: Peter Krempa <pkrempa@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
292 lines
8.6 KiB
C
292 lines
8.6 KiB
C
/*
|
|
* Virtio SCSI dataplane
|
|
*
|
|
* Copyright Red Hat, Inc. 2014
|
|
*
|
|
* Authors:
|
|
* Fam Zheng <famz@redhat.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "qapi/error.h"
|
|
#include "hw/virtio/virtio-scsi.h"
|
|
#include "qemu/error-report.h"
|
|
#include "system/block-backend.h"
|
|
#include "hw/scsi/scsi.h"
|
|
#include "scsi/constants.h"
|
|
#include "hw/virtio/iothread-vq-mapping.h"
|
|
#include "hw/virtio/virtio-bus.h"
|
|
|
|
/* Context: BQL held */
|
|
void virtio_scsi_dataplane_setup(VirtIOSCSI *s, Error **errp)
|
|
{
|
|
VirtIOSCSICommon *vs = VIRTIO_SCSI_COMMON(s);
|
|
VirtIODevice *vdev = VIRTIO_DEVICE(s);
|
|
BusState *qbus = qdev_get_parent_bus(DEVICE(vdev));
|
|
VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus);
|
|
|
|
if (vs->conf.iothread && vs->conf.iothread_vq_mapping_list) {
|
|
error_setg(errp,
|
|
"iothread and iothread-vq-mapping properties cannot be set "
|
|
"at the same time");
|
|
return;
|
|
}
|
|
|
|
if (vs->conf.iothread || vs->conf.iothread_vq_mapping_list) {
|
|
if (!k->set_guest_notifiers || !k->ioeventfd_assign) {
|
|
error_setg(errp,
|
|
"device is incompatible with iothread "
|
|
"(transport does not support notifiers)");
|
|
return;
|
|
}
|
|
if (!virtio_device_ioeventfd_enabled(vdev)) {
|
|
error_setg(errp, "ioeventfd is required for iothread");
|
|
return;
|
|
}
|
|
}
|
|
|
|
s->vq_aio_context = g_new(AioContext *, vs->conf.num_queues +
|
|
VIRTIO_SCSI_VQ_NUM_FIXED);
|
|
|
|
/*
|
|
* Handle the ctrl virtqueue in the main loop thread where device resets
|
|
* can be performed.
|
|
*/
|
|
s->vq_aio_context[0] = qemu_get_aio_context();
|
|
|
|
/*
|
|
* Handle the event virtqueue in the main loop thread where its no_poll
|
|
* behavior won't stop IOThread polling.
|
|
*/
|
|
s->vq_aio_context[1] = qemu_get_aio_context();
|
|
|
|
if (vs->conf.iothread_vq_mapping_list) {
|
|
if (!iothread_vq_mapping_apply(vs->conf.iothread_vq_mapping_list,
|
|
&s->vq_aio_context[VIRTIO_SCSI_VQ_NUM_FIXED],
|
|
vs->conf.num_queues, errp)) {
|
|
g_free(s->vq_aio_context);
|
|
s->vq_aio_context = NULL;
|
|
return;
|
|
}
|
|
} else if (vs->conf.iothread) {
|
|
AioContext *ctx = iothread_get_aio_context(vs->conf.iothread);
|
|
for (uint16_t i = 0; i < vs->conf.num_queues; i++) {
|
|
s->vq_aio_context[VIRTIO_SCSI_VQ_NUM_FIXED + i] = ctx;
|
|
}
|
|
|
|
/* Released in virtio_scsi_dataplane_cleanup() */
|
|
object_ref(OBJECT(vs->conf.iothread));
|
|
} else {
|
|
AioContext *ctx = qemu_get_aio_context();
|
|
for (unsigned i = 0; i < vs->conf.num_queues; i++) {
|
|
s->vq_aio_context[VIRTIO_SCSI_VQ_NUM_FIXED + i] = ctx;
|
|
}
|
|
}
|
|
}
|
|
|
|
/* Context: BQL held */
|
|
void virtio_scsi_dataplane_cleanup(VirtIOSCSI *s)
|
|
{
|
|
VirtIOSCSICommon *vs = VIRTIO_SCSI_COMMON(s);
|
|
|
|
if (vs->conf.iothread_vq_mapping_list) {
|
|
iothread_vq_mapping_cleanup(vs->conf.iothread_vq_mapping_list);
|
|
}
|
|
|
|
if (vs->conf.iothread) {
|
|
object_unref(OBJECT(vs->conf.iothread));
|
|
}
|
|
|
|
g_free(s->vq_aio_context);
|
|
s->vq_aio_context = NULL;
|
|
}
|
|
|
|
static int virtio_scsi_set_host_notifier(VirtIOSCSI *s, VirtQueue *vq, int n)
|
|
{
|
|
BusState *qbus = BUS(qdev_get_parent_bus(DEVICE(s)));
|
|
int rc;
|
|
|
|
/* Set up virtqueue notify */
|
|
rc = virtio_bus_set_host_notifier(VIRTIO_BUS(qbus), n, true);
|
|
if (rc != 0) {
|
|
fprintf(stderr, "virtio-scsi: Failed to set host notifier (%d)\n",
|
|
rc);
|
|
s->dataplane_fenced = true;
|
|
return rc;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
/* Context: BH in IOThread */
|
|
static void virtio_scsi_dataplane_stop_vq_bh(void *opaque)
|
|
{
|
|
AioContext *ctx = qemu_get_current_aio_context();
|
|
VirtQueue *vq = opaque;
|
|
EventNotifier *host_notifier;
|
|
|
|
virtio_queue_aio_detach_host_notifier(vq, ctx);
|
|
host_notifier = virtio_queue_get_host_notifier(vq);
|
|
|
|
/*
|
|
* Test and clear notifier after disabling event, in case poll callback
|
|
* didn't have time to run.
|
|
*/
|
|
virtio_queue_host_notifier_read(host_notifier);
|
|
}
|
|
|
|
/* Context: BQL held */
|
|
int virtio_scsi_dataplane_start(VirtIODevice *vdev)
|
|
{
|
|
int i;
|
|
int rc;
|
|
int vq_init_count = 0;
|
|
BusState *qbus = qdev_get_parent_bus(DEVICE(vdev));
|
|
VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus);
|
|
VirtIOSCSICommon *vs = VIRTIO_SCSI_COMMON(vdev);
|
|
VirtIOSCSI *s = VIRTIO_SCSI(vdev);
|
|
|
|
if (s->dataplane_started ||
|
|
s->dataplane_starting ||
|
|
s->dataplane_fenced) {
|
|
return 0;
|
|
}
|
|
|
|
s->dataplane_starting = true;
|
|
|
|
/* Set up guest notifier (irq) */
|
|
rc = k->set_guest_notifiers(qbus->parent, vs->conf.num_queues + 2, true);
|
|
if (rc != 0) {
|
|
error_report("virtio-scsi: Failed to set guest notifiers (%d), "
|
|
"ensure -accel kvm is set.", rc);
|
|
goto fail_guest_notifiers;
|
|
}
|
|
|
|
/*
|
|
* Batch all the host notifiers in a single transaction to avoid
|
|
* quadratic time complexity in address_space_update_ioeventfds().
|
|
*/
|
|
memory_region_transaction_begin();
|
|
|
|
rc = virtio_scsi_set_host_notifier(s, vs->ctrl_vq, 0);
|
|
if (rc != 0) {
|
|
goto fail_host_notifiers;
|
|
}
|
|
|
|
vq_init_count++;
|
|
rc = virtio_scsi_set_host_notifier(s, vs->event_vq, 1);
|
|
if (rc != 0) {
|
|
goto fail_host_notifiers;
|
|
}
|
|
|
|
vq_init_count++;
|
|
|
|
for (i = 0; i < vs->conf.num_queues; i++) {
|
|
rc = virtio_scsi_set_host_notifier(s, vs->cmd_vqs[i], i + 2);
|
|
if (rc) {
|
|
goto fail_host_notifiers;
|
|
}
|
|
vq_init_count++;
|
|
}
|
|
|
|
memory_region_transaction_commit();
|
|
|
|
s->dataplane_starting = false;
|
|
s->dataplane_started = true;
|
|
smp_wmb(); /* paired with aio_notify_accept() */
|
|
|
|
if (s->bus.drain_count == 0) {
|
|
virtio_queue_aio_attach_host_notifier(vs->ctrl_vq,
|
|
s->vq_aio_context[0]);
|
|
virtio_queue_aio_attach_host_notifier_no_poll(vs->event_vq,
|
|
s->vq_aio_context[1]);
|
|
|
|
for (i = 0; i < vs->conf.num_queues; i++) {
|
|
AioContext *ctx = s->vq_aio_context[VIRTIO_SCSI_VQ_NUM_FIXED + i];
|
|
virtio_queue_aio_attach_host_notifier(vs->cmd_vqs[i], ctx);
|
|
}
|
|
}
|
|
return 0;
|
|
|
|
fail_host_notifiers:
|
|
for (i = 0; i < vq_init_count; i++) {
|
|
virtio_bus_set_host_notifier(VIRTIO_BUS(qbus), i, false);
|
|
}
|
|
|
|
/*
|
|
* The transaction expects the ioeventfds to be open when it
|
|
* commits. Do it now, before the cleanup loop.
|
|
*/
|
|
memory_region_transaction_commit();
|
|
|
|
for (i = 0; i < vq_init_count; i++) {
|
|
virtio_bus_cleanup_host_notifier(VIRTIO_BUS(qbus), i);
|
|
}
|
|
k->set_guest_notifiers(qbus->parent, vs->conf.num_queues + 2, false);
|
|
fail_guest_notifiers:
|
|
s->dataplane_fenced = true;
|
|
s->dataplane_starting = false;
|
|
s->dataplane_started = true;
|
|
return -ENOSYS;
|
|
}
|
|
|
|
/* Context: BQL held */
|
|
void virtio_scsi_dataplane_stop(VirtIODevice *vdev)
|
|
{
|
|
BusState *qbus = qdev_get_parent_bus(DEVICE(vdev));
|
|
VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus);
|
|
VirtIOSCSICommon *vs = VIRTIO_SCSI_COMMON(vdev);
|
|
VirtIOSCSI *s = VIRTIO_SCSI(vdev);
|
|
int i;
|
|
|
|
if (!s->dataplane_started || s->dataplane_stopping) {
|
|
return;
|
|
}
|
|
|
|
/* Better luck next time. */
|
|
if (s->dataplane_fenced) {
|
|
s->dataplane_fenced = false;
|
|
s->dataplane_started = false;
|
|
return;
|
|
}
|
|
s->dataplane_stopping = true;
|
|
|
|
if (s->bus.drain_count == 0) {
|
|
for (i = 0; i < vs->conf.num_queues + VIRTIO_SCSI_VQ_NUM_FIXED; i++) {
|
|
VirtQueue *vq = virtio_get_queue(&vs->parent_obj, i);
|
|
AioContext *ctx = s->vq_aio_context[i];
|
|
aio_wait_bh_oneshot(ctx, virtio_scsi_dataplane_stop_vq_bh, vq);
|
|
}
|
|
}
|
|
|
|
blk_drain_all(); /* ensure there are no in-flight requests */
|
|
|
|
/*
|
|
* Batch all the host notifiers in a single transaction to avoid
|
|
* quadratic time complexity in address_space_update_ioeventfds().
|
|
*/
|
|
memory_region_transaction_begin();
|
|
|
|
for (i = 0; i < vs->conf.num_queues + 2; i++) {
|
|
virtio_bus_set_host_notifier(VIRTIO_BUS(qbus), i, false);
|
|
}
|
|
|
|
/*
|
|
* The transaction expects the ioeventfds to be open when it
|
|
* commits. Do it now, before the cleanup loop.
|
|
*/
|
|
memory_region_transaction_commit();
|
|
|
|
for (i = 0; i < vs->conf.num_queues + 2; i++) {
|
|
virtio_bus_cleanup_host_notifier(VIRTIO_BUS(qbus), i);
|
|
}
|
|
|
|
/* Clean up guest notifier (irq) */
|
|
k->set_guest_notifiers(qbus->parent, vs->conf.num_queues + 2, false);
|
|
s->dataplane_stopping = false;
|
|
s->dataplane_started = false;
|
|
}
|