motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-07 09:43:56 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

hw/intc/arm_gicv3_cpuif(): Remove redundant tests of is_a64()

Browse source 
In the gicv3_{irq,fiq,irqfiq}_access() functions, in the
arm_current_el(env) == 3 case we do the following test:
    if (!is_a64(env) && !arm_is_el3_or_mon(env)) {
        r = CP_ACCESS_TRAP_EL3;
    }

In this check, the "!is_a64(env)" is redundant, because if
we are at EL3 and in AArch64 then arm_is_el3_or_mon() will
return true and we will skip the if() body anyway.

Remove the unnecessary tests.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20250130182309.717346-9-peter.maydell@linaro.org
This commit is contained in:
Peter Maydell 2025-01-30 18:23:03 +00:00
parent 4d436fb05c
commit ff8b906a00
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
hw/intc/arm_gicv3_cpuif.c
View file

@ -2291,7 +2291,7 @@ static CPAccessResult gicv3_irqfiq_access(CPUARMState *env,
r = CP_ACCESS_TRAP_EL3; r = CP_ACCESS_TRAP_EL3;
break; break;
case 3: case 3:
if (!is_a64(env) && !arm_is_el3_or_mon(env)) { if (!arm_is_el3_or_mon(env)) {
r = CP_ACCESS_TRAP_EL3; r = CP_ACCESS_TRAP_EL3;
} }
break; break;
@ -2353,7 +2353,7 @@ static CPAccessResult gicv3_fiq_access(CPUARMState *env,
r = CP_ACCESS_TRAP_EL3; r = CP_ACCESS_TRAP_EL3;
break; break;
case 3: case 3:
if (!is_a64(env) && !arm_is_el3_or_mon(env)) { if (!arm_is_el3_or_mon(env)) {
r = CP_ACCESS_TRAP_EL3; r = CP_ACCESS_TRAP_EL3;
} }
break; break;
@ -2389,7 +2389,7 @@ static CPAccessResult gicv3_irq_access(CPUARMState *env,
r = CP_ACCESS_TRAP_EL3; r = CP_ACCESS_TRAP_EL3;
break; break;
case 3: case 3:
if (!is_a64(env) && !arm_is_el3_or_mon(env)) { if (!arm_is_el3_or_mon(env)) {
r = CP_ACCESS_TRAP_EL3; r = CP_ACCESS_TRAP_EL3;
} }
break; break;