motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-04 08:13:54 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

qemu-ga: add a whitelist for fsfreeze-safe commands

Browse source 
Currently we rely on fsfreeze/thaw commands disabling/enabling logging
then having other commands check whether logging is disabled to avoid
executing if they aren't safe for running while a filesystem is frozen.

Instead, have an explicit whitelist of fsfreeze-safe commands, and
consolidate logging and command enablement/disablement into a pair
of helper functions: ga_set_frozen()/ga_unset_frozen()

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
This commit is contained in:
Michael Roth 2012-04-17 19:01:45 -05:00
parent 9e8aded432
commit f22d85e9e6
5 changed files with 140 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

14
qapi/qmp-registry.c
View file

@ -40,18 +40,28 @@ QmpCommand *qmp_find_command(const char *name)
return NULL;
}
void qmp_disable_command(const char *name)
static void qmp_toggle_command(const char *name, bool enabled)
{
QmpCommand *cmd;
QTAILQ_FOREACH(cmd, &qmp_commands, node) {
if (strcmp(cmd->name, name) == 0) {
cmd->enabled = false;
cmd->enabled = enabled;
return;
}
}
}
void qmp_disable_command(const char *name)
{
qmp_toggle_command(name, false);
}
void qmp_enable_command(const char *name)
{
qmp_toggle_command(name, true);
}
bool qmp_command_is_enabled(const char *name)
{
QmpCommand *cmd;