motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-06 09:13:55 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

tests/qtest: Use qtest_add_data_func_full()

Browse source 
A test function may not be executed depending on the test command line
so it is wrong to free data with a test function. Use
qtest_add_data_func_full() to register a function to free data.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-ID: <20240627-san-v2-10-750bb0946dbd@daynix.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
This commit is contained in:
Akihiko Odaki 2024-06-27 22:37:53 +09:00 • committed by Thomas Huth
parent ada9311de3
commit eefd26b876
1 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
tests/qtest/device-introspect-test.c
View file

@ -266,7 +266,6 @@ static void test_device_intro_concrete(const void *args)
qobject_unref(types); qobject_unref(types);
qtest_quit(qts); qtest_quit(qts);
g_free((void *)args);
} }
static void test_abstract_interfaces(void) static void test_abstract_interfaces(void)
@ -310,12 +309,12 @@ static void add_machine_test_case(const char *mname)
path = g_strdup_printf("device/introspect/concrete/defaults/%s", mname); path = g_strdup_printf("device/introspect/concrete/defaults/%s", mname);
args = g_strdup_printf("-M %s", mname); args = g_strdup_printf("-M %s", mname);
qtest_add_data_func(path, args, test_device_intro_concrete); qtest_add_data_func_full(path, args, test_device_intro_concrete, g_free);
g_free(path); g_free(path);
path = g_strdup_printf("device/introspect/concrete/nodefaults/%s", mname); path = g_strdup_printf("device/introspect/concrete/nodefaults/%s", mname);
args = g_strdup_printf("-nodefaults -M %s", mname); args = g_strdup_printf("-nodefaults -M %s", mname);
qtest_add_data_func(path, args, test_device_intro_concrete); qtest_add_data_func_full(path, args, test_device_intro_concrete, g_free);
g_free(path); g_free(path);
} }
@ -330,7 +329,7 @@ int main(int argc, char **argv)
qtest_add_func("device/introspect/abstract-interfaces", test_abstract_interfaces); qtest_add_func("device/introspect/abstract-interfaces", test_abstract_interfaces);
if (g_test_quick()) { if (g_test_quick()) {
qtest_add_data_func("device/introspect/concrete/defaults/none", qtest_add_data_func("device/introspect/concrete/defaults/none",
g_strdup(common_args), test_device_intro_concrete); common_args, test_device_intro_concrete);
} else { } else {
qtest_cb_for_every_machine(add_machine_test_case, true); qtest_cb_for_every_machine(add_machine_test_case, true);
} }